Skip to content

Comments

Adding mcp client support#23

Merged
OriNachum merged 16 commits intomainfrom
feature/mcp-client-3
May 16, 2025
Merged

Adding mcp client support#23
OriNachum merged 16 commits intomainfrom
feature/mcp-client-3

Conversation

@OriNachum
Copy link
Collaborator

No description provided.

@OriNachum
Copy link
Collaborator Author

image
Current state

Message and parsing action result failed

@OriNachum OriNachum force-pushed the feature/mcp-client-3 branch from a45236b to e9f5f6c Compare May 15, 2025 23:20
@OriNachum
Copy link
Collaborator Author

Found a bug in tests, codex doesn't correctly test responses api.
It actually gives me light on the difference between chat mode and cli mode.
It means I can use that to see if behavior remains or not

@OriNachum
Copy link
Collaborator Author

OriNachum commented May 16, 2025

Issues in responses mode:

  1. MCP overrides existing tools by Codex
  2. Conversations are not passed between requests

@OriNachum
Copy link
Collaborator Author

Fixed in code:
MCP overrides existing tools by Codex

I am able to work with shell commands in chat mode

@OriNachum OriNachum marked this pull request as ready for review May 16, 2025 20:28
@sonarqubecloud
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
0.0% Coverage on New Code (required ≥ 80%)
B Security Rating on New Code (required ≥ A)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

@OriNachum OriNachum requested a review from Copilot May 16, 2025 20:37
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds MCP client support by introducing new tools and configuration files and updating project dependencies.

  • Added new bash scripts to call MCP and Codex endpoints.
  • Introduced MCP server configuration files for sqlite and updated pyproject.toml with new dependencies.
  • Added a helper Python function to check for MCP tools.

Reviewed Changes

Copilot reviewed 16 out of 16 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
test_tools/call_responses_proxy_mcp.sh New script for MCP responses proxy via curl
test_tools/call_responses_proxy.sh Updated input string for responses proxy
test_tools/call_codex_mcp.sh New script to call codex with MCP support
src/open_responses_server/servers_config.sqlite.json Added configuration for sqlite MCP server
src/open_responses_server/servers_config.json Added empty placeholder for MCP servers configuration
src/open_responses_server/servers_config.empty.json Added another empty placeholder configuration
src/open_responses_server/is_mcp_tool.py Added helper function to check for MCP tools in cache
pyproject.toml Updated Python version requirement and added new dependencies
docs/prompts/add-mcp-support.py Documentation prompt regarding MCP support
README.md Minor README update
Comments suppressed due to low confidence (1)

src/open_responses_server/is_mcp_tool.py:14

  • The variable 'mcp_functions_cache' is used without a defined value. Ensure it is properly defined or imported before use.
for func in mcp_functions_cache:

"flake8-bandit>=4.1.1",
"flake8-bugbear>=23.7.10"
"flake8-bugbear>=23.7.10",
"uvicorn>=0.32.1",
Copy link

Copilot AI May 16, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[nitpick] The uvicorn dependency version differs between the main dependencies (>=0.15.0) and dev dependencies (>=0.32.1). Consider aligning these versions or clearly documenting the version rationale.

Copilot uses AI. Check for mistakes.
@OriNachum OriNachum merged commit 877a4b3 into main May 16, 2025
8 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant