Merged
Conversation
Introduces *_each variants (git_tree_each, git_log_each, git_read_each, git_parents_each, git_branches_each, git_tags_each) that support dynamic parameters for LATERAL joins. Existing functions remain unchanged. Architecture changes: - Extract git functions from monolithic git_functions.cpp into separate files - Add GitContextManager for centralized URI validation - Implement per-thread repository caching (50-80% performance improvement) Documentation: - Add git_context_manager.md, advanced_examples.md, git_uris.md - Add testing_strategy.md Tests: - 46 test cases with 736 assertions - Comprehensive LATERAL join and thread-safety coverage - Automated test fixture infrastructure No breaking changes - all original signatures preserved.
…ions Add LATERAL join support for git table functions
Signed-off-by: Teague Sterling <teaguesterling@gmail.com>
Signed-off-by: Teague Sterling <teaguesterling@gmail.com>
Owner
Author
|
@alexkwolfe I noticed that the Makefile had been changed leading to its default behavior no longer working. Was that intentional? |
Add std::move() to enable implicit conversion from unique_ptr<GitLogFunctionData> to unique_ptr<FunctionData>. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
- Create test/Makefile.inc with fixture extraction logic - Add optional include from main Makefile (-include) - Fixtures are automatically set up before test targets run This keeps the main Makefile minimal while properly integrating the test fixture setup from the contributor's PR. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
Replace manual Unix-style path walking with libgit2's native discovery mechanism for proper Windows and submodule support. Changes: - Use git_repository_discover() for cross-platform path resolution - Use git_repository_workdir() to correctly handle submodules - Fall back to git_repository_path() for bare repositories This fixes Windows CI test failures where mingw-style paths weren't being handled correctly, and also fixes submodule queries that were returning empty results. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
- Add cross-platform support note (Linux, macOS, Windows) - Document git submodule query support - Update test counts to 736 assertions across 46 test cases - Clean up duplicated content in Current Status section - Add LATERAL join support documentation 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
Signed-off-by: Teague Sterling <teaguesterling@gmail.com>
Signed-off-by: Teague Sterling <teaguesterling@gmail.com>
Signed-off-by: Teague Sterling <teaguesterling@gmail.com>
Signed-off-by: Teague Sterling <teaguesterling@gmail.com>
Signed-off-by: Teague Sterling <teaguesterling@gmail.com>
The Windows builds were still running because the exclusion list had "windows_amd64_minigw" instead of "windows_amd64_mingw" (extra 'i'). 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
Standardizes indentation (spaces to tabs) and reformats code to match DuckDB style guide in preparation for enabling code quality CI checks. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
- Add test/fixtures/test_repo~/ to .gitignore - Enable format check in CI (tidy disabled for now due to libgit2 deps) 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
- Add test/fixtures/test_repo~/ to .gitignore - Enable format check in CI (tidy disabled for now due to libgit2 deps) 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
Signed-off-by: Teague Sterling <teaguesterling@gmail.com>
Signed-off-by: Teague Sterling <teaguesterling@gmail.com>
Signed-off-by: Teague Sterling <teaguesterling@gmail.com>
Contributor
|
@teaguesterling Sorry! Just now seeing your question. Dang it. That was unintentional. The lines adding dependencies to I was trying to ensure test fixtures were set up before running tests. Maybe wrapper targets like below would be better? Not sure the idiomatic way to handle this. Thoughts? |
Owner
Author
|
No worries! I was able to get your changes integrated! Will be releasing an updated soon. Thank you for the PR (and will make sure to credit you 😀) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.