Closed
Conversation
Using `--color=always` provides color output when piping color through ANSI-control-sequence aware processes such as `less -R` and `which -c`. However, these programs are not aware of ANSI-operating-system-command sequences. A simple solution here is to filter out the one decor that uses ANSI-operating-system-command, `linked_uri`.
euclidianAce
requested changes
Mar 10, 2025
Member
euclidianAce
left a comment
euclidianAce
left a comment
There was a problem hiding this comment.
Just some minor nits. Thanks!
| --- create_logger: function( | ||
| --- stream: FILE, | ||
| --- verbosity_threshold: Verbosity, | ||
| --- color_mode: ColorMode, |
Member
There was a problem hiding this comment.
color_mode isn't a parameter to create_logger, is it meant to be?
Comment on lines
+117
to
+119
| if decor then | ||
| decor.linked_uri = nil | ||
| end |
Member
There was a problem hiding this comment.
This is probably fine in practice, but I'm not a huge fan of modifying arguments like this. Not saying that this is a blocker, but maybe render_ansi could take another parameter like dont_render_uris: boolean or something.
Member
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.