Merged
Conversation
… feat/801-manager-vote-setting
ryujaemin08
requested review from
4mjeo,
alsdl0629,
ilyoil2,
rlaisqls,
tedsoftj1123 and
zios0707
as code owners
Closed
ilyoil2
reviewed
Feb 14, 2025
dms-core/src/main/kotlin/team/aliens/dms/domain/vote/usecase/CreateVotingTopicUseCase.kt
Outdated
Show resolved
Hide resolved
dms-core/src/main/kotlin/team/aliens/dms/domain/vote/usecase/DeleteVotingTopicUseCase.kt
Outdated
Show resolved
Hide resolved
dms-core/src/main/kotlin/team/aliens/dms/domain/vote/usecase/UpdateVotingTopicUseCase.kt
Outdated
Show resolved
Hide resolved
ilyoil2
reviewed
Feb 18, 2025
dms-core/src/main/kotlin/team/aliens/dms/domain/vote/service/ValidVotePeriodServiceImpl.kt
Outdated
Show resolved
Hide resolved
dms-core/src/main/kotlin/team/aliens/dms/domain/vote/service/ValidVotePeriodServiceImpl.kt
Outdated
Show resolved
Hide resolved
dms-core/src/main/kotlin/team/aliens/dms/domain/vote/service/ValidVotePeriodServiceImpl.kt
Outdated
Show resolved
Hide resolved
...core/src/main/kotlin/team/aliens/dms/domain/vote/service/VoteResultNoticeSchedulerService.kt
Outdated
Show resolved
Hide resolved
.../src/main/kotlin/team/aliens/dms/domain/vote/service/VoteResultNoticeSchedulerServiceImpl.kt
Outdated
Show resolved
Hide resolved
ilyoil2
reviewed
Feb 18, 2025
.../src/main/kotlin/team/aliens/dms/domain/vote/service/VoteResultNoticeSchedulerServiceImpl.kt
Outdated
Show resolved
Hide resolved
dms-core/src/main/kotlin/team/aliens/dms/domain/vote/service/GetVotingTopicService.kt
Outdated
Show resolved
Hide resolved
4mjeo
reviewed
Feb 21, 2025
dms-core/src/main/kotlin/team/aliens/dms/domain/vote/service/VoteService.kt
Show resolved
Hide resolved
dms-core/src/main/kotlin/team/aliens/dms/domain/vote/spi/CommendVotingTopicPort.kt
Outdated
Show resolved
Hide resolved
dms-core/src/main/kotlin/team/aliens/dms/domain/vote/usecase/CreateVotingTopicUseCase.kt
Show resolved
Hide resolved
dms-core/src/main/kotlin/team/aliens/dms/domain/vote/usecase/UpdateVotingTopicUseCase.kt
Outdated
Show resolved
Hide resolved
...ersistence/src/main/kotlin/team/aliens/dms/persistence/vote/VotingTopicPersistenceAdapter.kt
Outdated
Show resolved
Hide resolved
4mjeo
reviewed
Feb 21, 2025
dms-core/src/main/kotlin/team/aliens/dms/domain/vote/usecase/UpdateVotingTopicUseCase.kt
Outdated
Show resolved
Hide resolved
...nfrastructure/src/main/kotlin/team/aliens/dms/scheduler/taskschduler/TaskSchedulerAdepter.kt
Outdated
Show resolved
Hide resolved
4mjeo
reviewed
Feb 21, 2025
Member
4mjeo
left a comment
4mjeo
left a comment
There was a problem hiding this comment.
exception 들은 votingTopicExceptions에 다 넣어주세요 그리고 예외 네이밍도 수정 해주세요
ex) NotFoundVotingTopicException (X) VotingTopicNotFoundException (O)
...ation/src/main/kotlin/team/aliens/dms/domain/vote/dto/request/UpdateVotingTopicWebRequest.kt
Outdated
Show resolved
Hide resolved
...re/src/main/kotlin/team/aliens/dms/scheduler/error/exception/TaskSchedulingErrorException.kt
Outdated
Show resolved
Hide resolved
dms-infrastructure/src/main/kotlin/team/aliens/dms/scheduler/error/SchdulerErrorCode.kt
Outdated
Show resolved
Hide resolved
dms-infrastructure/src/main/kotlin/team/aliens/dms/scheduler/error/SchdulerErrorCode.kt
Outdated
Show resolved
Hide resolved
dms-infrastructure/src/main/kotlin/team/aliens/dms/scheduler/error/SchdulerErrorCode.kt
Outdated
Show resolved
Hide resolved
dms-infrastructure/src/main/kotlin/team/aliens/dms/scheduler/config/TaskSchedulerConfig.kt
Outdated
Show resolved
Hide resolved
dms-infrastructure/src/main/kotlin/team/aliens/dms/scheduler/config/TaskSchedulerConfig.kt
Outdated
Show resolved
Hide resolved
dms-infrastructure/src/main/kotlin/team/aliens/dms/global/security/SecurityConfig.kt
Outdated
Show resolved
Hide resolved
dms-core/src/main/kotlin/team/aliens/dms/domain/vote/spi/VotingTopicPort.kt
Outdated
Show resolved
Hide resolved
4mjeo
reviewed
Feb 21, 2025
dms-core/src/main/kotlin/team/aliens/dms/domain/vote/exception/error/VotingTopicErrorCode.kt
Outdated
Show resolved
Hide resolved
dms-core/src/main/kotlin/team/aliens/dms/domain/notice/service/CommandNoticeServiceImpl.kt
Show resolved
Hide resolved
4mjeo
approved these changes
Feb 24, 2025
ilyoil2
approved these changes
Feb 24, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
작업 내용 설명
사감쌤 투표 api 추가
taskScheduler 로 백그라운드 비동기 투표결과 공지 생성
주요 변경 사항
결과물
체크리스트
관련 이슈