fix: exclude SKILL-DIAGNOSTIC.json from validation scans#40
Open
aisling404 wants to merge 1 commit intomainfrom
Open
fix: exclude SKILL-DIAGNOSTIC.json from validation scans#40aisling404 wants to merge 1 commit intomainfrom
aisling404 wants to merge 1 commit intomainfrom
Conversation
The post-test diagnostic tool writes SKILL-DIAGNOSTIC.json which contains references to Twilio patterns (like hmac_sha1) from its own analysis output. When validate-migration.sh runs again, it scans this file and reports false positives. Adding it to the exclude list prevents this self-referencing issue. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
SKILL-DIAGNOSTIC.jsonto the excluded files list invalidate-migration.shhmac_sha1) from its own analysis, causingvalidate-migration.shto flag them as unmigrated codeTest plan
validate-migration.shon a project that has aSKILL-DIAGNOSTIC.jsonin its root — confirm no false positives from diagnostic outputvalidate-migration.shon a project withoutSKILL-DIAGNOSTIC.json— confirm no behavior change🤖 Generated with Claude Code