This repository was archived by the owner on Jan 11, 2025. It is now read-only.
Open
Conversation
jasper77
reviewed
Feb 27, 2020
|
|
||
| /** | ||
| * | ||
| * @param distance distance to move in feet |
jasper77
reviewed
Feb 27, 2020
| case "Collect And Shoot": | ||
| autonomous = Actions.collectAndShoot(); | ||
| break; | ||
| case "Shoot from LB": |
There was a problem hiding this comment.
"case" statements should be column aligned
john-petrangelo
approved these changes
Feb 27, 2020
Contributor
john-petrangelo
left a comment
john-petrangelo
left a comment
There was a problem hiding this comment.
It's hard to review this quickly. It's no worse than before in any case, approved, but needs lots of testing.
| } | ||
|
|
||
| public static final Action drive(double duration) { | ||
| String actionText = "Do Nothing"; |
Contributor
There was a problem hiding this comment.
Action text is wrong,
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
adds some modes for autonomous