Add a whenHeld to a custom trigger class#162
Open
TechplexEngineer wants to merge 1 commit intotestingfrom
Open
Add a whenHeld to a custom trigger class#162TechplexEngineer wants to merge 1 commit intotestingfrom
TechplexEngineer wants to merge 1 commit intotestingfrom
Conversation
If/When they merge wpilibsuite/allwpilib#1643
TechplexEngineer
requested review from
ashwinc12,
derrell and
roshanr10
as code owners
roshanr10
approved these changes
Mar 19, 2019
derrell
suggested changes
Mar 19, 2019
Contributor
derrell
left a comment
derrell
left a comment
There was a problem hiding this comment.
I'm not so sure about this. I think it's a bad idea to be mixing use of BionicTrigger and Trigger. We should use native stuff, or use our own wrapper, but not both. How about adding the required functionality included here into BionicTrigger?
Contributor
|
if we're going to be doing this, why don't we inherit BionicTrigger from Trigger so they're more interchangeable? if your PR goes through, then it'll become native and no changes to be made |
Member
Author
|
@roshanr10 It would be good for someone to try to extend Trigger, but I was running into access issues. Please do try. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If/When they merge wpilibsuite/allwpilib#1643 we can remove this shim