[With or Without IDs] Export and Import should be possible without IDs

README.md

@@ -75,6 +75,18 @@ All import commands follow a similar structure and support the following common
 - `--input` or `-i`: Path to the input YAML file (required for import commands).
 - `--dry-run`: Perform the operation without persisting data (only available for import commands).
 
+### Notice: WYSIWYG - Editable
+
+For using a correct exporting and importing of WYSIWYG editables in older Pimcore versions (e.g. using `symfony/framework < 6.2.2`) you probably need to configure your Symfony HTML sanitizer as documented here:
+https://docs.pimcore.com/platform/2024.4/Pimcore/Documents/Editables/WYSIWYG#extending-symfony-html-sanitizer-configuration
+
+In our integration test we have used the following configuration:
+
+```yaml
+tests/app/config/packages/pimcore.yaml
+```
+because of already known bugs with `<a>` - HTML tag.
+
 ## Concepts
 
 ### Page Export

composer.json

@@ -34,11 +34,14 @@
     "phpstan/phpstan": "^1.10.60",
     "phpstan/phpstan-phpunit": "^1.3.16",
     "phpstan/phpstan-symfony": "^1.3.8",
-    "phpunit/phpunit": "^9.5",
-    "pimcore/admin-ui-classic-bundle": "^1.6",
+    "phpunit/phpunit": "^9.6",
+    "pimcore/admin-ui-classic-bundle": "^1.0",
     "spatie/phpunit-snapshot-assertions": "^4.2",
     "teamneusta/pimcore-testing-framework": "^0.12"
   },
+  "conflict": {
+    "masterminds/html5": "< 2.8.1"
+  },
   "autoload": {
     "psr-4": {
       "Neusta\\Pimcore\\ImportExportBundle\\": "src/"

config/pimcore/export/assets/converters_populators.yaml

@@ -8,12 +8,12 @@ neusta_converter:
     ###########################################################
     neusta_pimcore_import_export.export_asset_folder:
       target: Neusta\Pimcore\ImportExportBundle\Model\Asset\Asset
+      populators:
+        - Neusta\Pimcore\ImportExportBundle\Populator\IdsPopulator
       properties:
-        id: ~
         key: ~
         type: ~
         path: ~
-        parentId: ~
 
 services:
   _defaults:
@@ -87,6 +87,8 @@ services:
   ###########################################################
   # Export Populator (Pimcore Asset -> Asset)
   ###########################################################
+  Neusta\Pimcore\ImportExportBundle\Populator\IdsPopulator: ~
+
   neusta_pimcore_import_export.asset.filename.populator:
     class: Neusta\ConverterBundle\Populator\PropertyMappingPopulator
     arguments:

config/pimcore/export/documents/converters_populators.yaml

@@ -9,17 +9,51 @@ neusta_converter:
     neusta_pimcore_import_export.export_document:
       target: Neusta\Pimcore\ImportExportBundle\Model\Document\Document
       populators:
-        - neusta_pimcore_import_export.page.property.language.populator
-        - neusta_pimcore_import_export.page.property.navigation_title.populator
-        - neusta_pimcore_import_export.page.property.navigation_name.populator
+        - Neusta\Pimcore\ImportExportBundle\Populator\IdsPopulator
+        - neusta_pimcore_import_export.document.properties.populator
+      properties:
+        key: ~
+        type: ~
+        published: ~
+        path: ~
+
+    neusta_pimcore_import_export.export_folder:
+      target: Neusta\Pimcore\ImportExportBundle\Model\Document\Folder
+      populators:
+        - Neusta\Pimcore\ImportExportBundle\Populator\IdsPopulator
+        - neusta_pimcore_import_export.document.properties.populator
+      properties:
+        key: ~
+        type: ~
+        published: ~
+        path: ~
+
+    neusta_pimcore_import_export.export_page_snippet:
+      target: Neusta\Pimcore\ImportExportBundle\Model\Document\PageSnippet
+      populators:
+        - Neusta\Pimcore\ImportExportBundle\Populator\IdsPopulator
+        - neusta_pimcore_import_export.page_snippet.controller.populator
+        - neusta_pimcore_import_export.page_snippet.editables.populator
+        - neusta_pimcore_import_export.document.properties.populator
+      properties:
+        key: ~
+        type: ~
+        published: ~
+        path: ~
+
+    neusta_pimcore_import_export.export_page:
+      target: Neusta\Pimcore\ImportExportBundle\Model\Document\Page
+      populators:
+        - Neusta\Pimcore\ImportExportBundle\Populator\IdsPopulator
+        - neusta_pimcore_import_export.page_snippet.controller.populator
+        - neusta_pimcore_import_export.page_snippet.editables.populator
+        - neusta_pimcore_import_export.page.title.populator
+        - neusta_pimcore_import_export.document.properties.populator
       properties:
-        id: ~
         key: ~
         type: ~
         published: ~
         path: ~
-        parentId: ~
-        controller: ~
 
     neusta_pimcore_import_export.editable_converter:
       target: Neusta\Pimcore\ImportExportBundle\Model\Document\Editable
@@ -29,6 +63,14 @@ neusta_converter:
         type: ~
         name: ~
 
+    neusta_pimcore_import_export.property_converter:
+      target: Neusta\Pimcore\ImportExportBundle\Model\Property
+      populators:
+        - Neusta\Pimcore\ImportExportBundle\Populator\PropertyValuePopulator
+      properties:
+        key: name
+        type: ~
+
 services:
   _defaults:
     autowire: true
@@ -42,52 +84,28 @@ services:
     arguments:
       $typeToConverterMap:
         Pimcore\Model\Document\Page: '@neusta_pimcore_import_export.export_page'
-        Pimcore\Model\Document\Snippet: '@neusta_pimcore_import_export.export_page_snippet'
+        Pimcore\Model\Document\PageSnippet: '@neusta_pimcore_import_export.export_page_snippet'
         Pimcore\Model\Document\Folder: '@neusta_pimcore_import_export.export_folder'
-
-  ###########################################################
-  # Export Converter (Document/Folder -> Page)
-  ###########################################################
-  neusta_pimcore_import_export.export_folder:
-    alias: neusta_pimcore_import_export.export_document
-
-  ###########################################################
-  # Export Converter (Document/PageSnippet -> Page)
-  ###########################################################
-  neusta_pimcore_import_export.export_page_snippet:
-    class: Neusta\Pimcore\ImportExportBundle\Converter\ExtendedConverter
-    arguments:
-      $converter: '@neusta_pimcore_import_export.export_document'
-      $postPopulators:
-        - '@neusta_pimcore_import_export.page.editables.populator'
-
-  ###########################################################
-  # Export Converter (Document/Page -> Page)
-  ###########################################################
-  neusta_pimcore_import_export.export_page:
-    class: Neusta\Pimcore\ImportExportBundle\Converter\ExtendedConverter
-    arguments:
-      $converter: '@neusta_pimcore_import_export.export_page_snippet'
-      $postPopulators:
-        - '@neusta_pimcore_import_export.page.controller.populator'
-        - '@neusta_pimcore_import_export.page.title.populator'
+        Pimcore\Model\Document: '@neusta_pimcore_import_export.export_document'
 
   ###########################################################
   # Export Populator (Page -> Page)
   ###########################################################
+  Neusta\Pimcore\ImportExportBundle\Populator\IdsPopulator: ~
+
   neusta_pimcore_import_export.page.title.populator:
     class: Neusta\ConverterBundle\Populator\PropertyMappingPopulator
     arguments:
       $sourceProperty: title
       $targetProperty: title
 
-  neusta_pimcore_import_export.page.controller.populator:
+  neusta_pimcore_import_export.page_snippet.controller.populator:
     class: Neusta\ConverterBundle\Populator\PropertyMappingPopulator
     arguments:
       $sourceProperty: controller
       $targetProperty: controller
 
-  neusta_pimcore_import_export.page.editables.populator:
+  neusta_pimcore_import_export.page_snippet.editables.populator:
     class: Neusta\ConverterBundle\Populator\ArrayConvertingPopulator
     arguments:
       $converter: '@neusta_pimcore_import_export.editable_converter'
@@ -101,23 +119,17 @@ services:
       $targetProperty: 'language'
       $skipNull: true
 
-  neusta_pimcore_import_export.page.property.navigation_title.populator:
-    class: Neusta\Pimcore\ImportExportBundle\PimcoreConverter\Populator\PropertyBasedMappingPopulator
-    arguments:
-      $propertyKey: 'navigation_title'
-      $targetProperty: 'navigation_title'
-      $skipNull: true
-
-  neusta_pimcore_import_export.page.property.navigation_name.populator:
-    class: Neusta\Pimcore\ImportExportBundle\PimcoreConverter\Populator\PropertyBasedMappingPopulator
+  neusta_pimcore_import_export.document.properties.populator:
+    class: Neusta\ConverterBundle\Populator\ArrayConvertingPopulator
     arguments:
-      $propertyKey: 'navigation_name'
-      $targetProperty: 'navigation_name'
-      $skipNull: true
+      $converter: '@neusta_pimcore_import_export.property_converter'
+      $sourceArrayPropertyName: 'properties'
+      $targetPropertyName: 'properties'
 
   ###########################################################
   # Export Populator (Editable -> YamlEditable)
   ###########################################################
   neusta_pimcore_import_export.editable.data.populator:
     class: Neusta\Pimcore\ImportExportBundle\Populator\EditableDataPopulator
 
+  Neusta\Pimcore\ImportExportBundle\Populator\PropertyValuePopulator: ~

config/pimcore/export/elements/converters_populators.yaml

@@ -8,9 +8,16 @@ neusta_converter:
     ###########################################################
     neusta_pimcore_import_export.export_element:
       target: Neusta\Pimcore\ImportExportBundle\Model\Element
+      populators:
+        - Neusta\Pimcore\ImportExportBundle\Populator\IdsPopulator
       properties:
-        id: ~
         key: ~
         type: ~
         path: ~
-        parentId: ~
+
+services:
+  _defaults:
+    autowire: true
+    autoconfigure: true
+
+  Neusta\Pimcore\ImportExportBundle\Populator\IdsPopulator: ~

config/pimcore/export/objects/converters_populators.yaml

@@ -9,16 +9,15 @@ neusta_converter:
     neusta_pimcore_import_export.export_object:
       target: Neusta\Pimcore\ImportExportBundle\Model\Object\DataObject
       populators:
+        - Neusta\Pimcore\ImportExportBundle\Populator\IdsPopulator
         - neusta_pimcore_import_export.export_object.fields.populator
         - neusta_pimcore_import_export.export_object.relations.populator
       properties:
         className: ~
-        id: ~
         key: ~
         type: ~
         published: ~
         path: ~
-        parentId: ~
 
     neusta_pimcore_import_export.export_object.without.relations:
       target: Neusta\Pimcore\ImportExportBundle\Model\Object\DataObject
@@ -47,6 +46,8 @@ services:
       $typeToConverterMap:
         Pimcore\Model\DataObject\Concrete: '@neusta_pimcore_import_export.export_object'
 
+  Neusta\Pimcore\ImportExportBundle\Populator\IdsPopulator: ~
+
   neusta_pimcore_import_export.export_object.fields.populator:
     class: Neusta\Pimcore\ImportExportBundle\Populator\DataObjectExportFieldsPopulator
 

config/pimcore/import/documents/converters_populators.yaml

@@ -7,6 +7,16 @@ neusta_converter:
     # Import Converter (Page -> PimcorePage)
     ###########################################################
     neusta_pimcore_import_export.import_document:
+      target: Pimcore\Model\Document
+      populators:
+        - neusta_pimcore_import_export.documents.import.populator.id
+        - neusta_pimcore_import_export.documents.import.populator.key
+        - neusta_pimcore_import_export.documents.import.populator.type
+        - neusta_pimcore_import_export.documents.import.populator.published
+        - neusta_pimcore_import_export.documents.import.populator.path
+        - neusta_pimcore_import_export.documents.import.populator.parentId
+
+    neusta_pimcore_import_export.import_page:
       target: Pimcore\Model\Document\Page
       populators:
         - neusta_pimcore_import_export.documents.import.populator.id
@@ -19,6 +29,18 @@ neusta_converter:
         - neusta_pimcore_import_export.documents.import.populator.parentId
         - Neusta\Pimcore\ImportExportBundle\Populator\PageImportPopulator
 
+    neusta_pimcore_import_export.import_page_snippet:
+      target: Pimcore\Model\Document\PageSnippet
+      populators:
+        - neusta_pimcore_import_export.documents.import.populator.id
+        - neusta_pimcore_import_export.documents.import.populator.key
+        - neusta_pimcore_import_export.documents.import.populator.controller
+        - neusta_pimcore_import_export.documents.import.populator.type
+        - neusta_pimcore_import_export.documents.import.populator.published
+        - neusta_pimcore_import_export.documents.import.populator.path
+        - neusta_pimcore_import_export.documents.import.populator.parentId
+        - Neusta\Pimcore\ImportExportBundle\Populator\PageImportPopulator
+
 services:
   _defaults:
     autowire: true