Merged
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR exposes the /actuator/health endpoint and enables detailed health information by updating the application YAML configuration.
- Added
healthto the list of exposed web endpoints undermanagement.endpoints.web.exposure.include. - Enabled full health details via
management.endpoint.health.show-details: always.
Comments suppressed due to low confidence (1)
src/main/resources/application.yml:61
- [nitpick] Consider using a YAML list for multiple items in
management.endpoints.web.exposure.include(e.g.,include: [prometheus, health]or using dash notation) for improved readability and to avoid parsing ambiguity.
include: prometheus,health
| prometheus: | ||
| enabled: true | ||
| health: | ||
| show-details: always |
There was a problem hiding this comment.
Enabling show-details: always exposes sensitive health information to all clients. Consider restricting this in production or adding access controls to prevent unintended information disclosure.
Member
Author
There was a problem hiding this comment.
현재는 staging 단계까지 적용할 계획을 가지고 있어서 현재 상태를 유지해도 될 것 같다는 판단이 들었습니다! staging 단계에서는 상세한 정보를 볼 수 있는 게 좋다고 판단되었기 때문입니다. 다만, 운영 환경 배포하는 시점에는 피드백 대로 when_authorized or never을 적용하여 관리하겠습니다!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📄 Work Description
/actuator/health엔드포인트가 웹에 노출되지 않아 접근이 불가능했던 문제를 해결했습니다.application.yml파일의management.endpoints.web.exposure.include설정에health를 추가하여 엔드포인트를 정상적으로 활성화했습니다.💬 To Reviewers
health엔드포인트를 노출하는 설정이 누락되어 헬스 체크가 실패하는 문제가 있었습니다. 해당 설정을 추가하여 문제를 해결하는 간단한 수정입니다. 확인 부탁드립니다!