Closed
Conversation
Variant records are not really required and cannot be translated into Java/Javascript
The reference is not used as reference but always as value throughout the whole code. Value assignment make memory management easier for the compiler and allow targets which do not support references to elementary types, e.g. Javascript
Collaborator
|
please re-clone the repository and re-PR. I tried to clear the history of the |
Collaborator
|
it may be best to wait with cloning until GitHub clears the repository - this can take up to 72 hours. |
Collaborator
|
ok. fork again, or get fresh clone - repo is ready. |
Contributor
Author
|
New brach created, #167 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello tebe,
as discussed here the first part of the compatibility changes for the PAS2JS target.
Use regular records instead of variant records
Use TString instead of ^TString for names in TToken
Kind regards, Peter.