Fix Ppqn Assertion in DEBUG. #30
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Any ppqn midi tracks will throw an asserion if division is less than PpqnMinValue when AssertValid() is called. This is called in Format as well as TrackCount during Read() while division is set to 0 beforehand. Solution: Set Division FIRST during Read.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Any
Ppqnmidi tracks will throw an assertion ifdivisionis less thanPpqnMinValuewhenAssertValid()is called.AssertValid()is called inset_Formatas well asset_TrackCountduringRead(Stream)whiledivisionis set to 0 beforehand.Solution: Set
DivisionFIRST duringRead(Stream).