Improve/fix array/pointer support in dizy#4
Open
ClearlyClaire wants to merge 2 commits intotech-srl:masterfrom
Open
Improve/fix array/pointer support in dizy#4ClearlyClaire wants to merge 2 commits intotech-srl:masterfrom
ClearlyClaire wants to merge 2 commits intotech-srl:masterfrom
Conversation
…core Previously, dizy only took into account variable initialization for integer variables. Extend this to pointer variables, as in SCORE, in order for array parameters to be correctly aliased.
dizy handles array access by discriminating against the type of the lvalue
and the rvalue, and checking whether they are pointer types.
However, LLVM makes a distinction between pointer values (int *foo) and array
values (int foo[2]). Therefore, on the following piece of code:
int foo[2];
foo[x] = 42;
dizy would lead to the following nonsensical interpretation:
{ foo - 42 = 0 }
instead of:
{ update( foo , idx ) - 42 = 0
idx - 2 = 0 }
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi,
There are a few issues preventing dizy from working correctly with arrays.
Thus, dizy cannot infer any meaningful relation between accesses of the same input array in the original and modified version of the program, thus badly affecting dizy's precision when one of the input parameters is a pointer. This is fixed in the first commit by extending initial value handling to pointer values, as it is done in SCORE.
On a side note, “ccc” may produce incorrect correlating programs by aliasing pointers from the original version and the modified version together. While it might be mitigated by dizy's rules (I haven't checked yet), it is still a fundamental issue with “ccc”. This is not a fundamental problem with SCORE (I haven't checked how the implementation handles it, though).