Skip to content

Conversation

wallem89
Copy link

@wallem89 wallem89 commented Nov 6, 2024

To be able to print signals with an enum with no_std I added defmt to format the enum values so they can be printed for debugging right away. This is done with an optional flag to enable this feature.

@projectgus
Copy link
Contributor

@wallem89 I saw your PR and remembered I implemented defmt support a couple of months back, too. 🤦

I've submitted it as #91. It's similar to yours but I also implemented Format for message structs.

@wallem89
Copy link
Author

@wallem89 I saw your PR and remembered I implemented defmt support a couple of months back, too. 🤦

I've submitted it as #91. It's similar to yours but I also implemented Format for message structs.

Your PR works for me too. And i like the Format for the message structs. Let's get yours merged and into a next release!

@linusharberg
Copy link
Collaborator

#91 merged, closing this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants