Remove uses of reduce/spread #463
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove uses of reduce/spread which causes significant latency to large middlewares. This is a port of (maticzav/graphql-middleware#567), which can be reproduced with
git fetch https://github.com/maticzav/graphql-middleware.git e9eac82fc16723a1549e15bdaf370063572052a6 && git cherry-pick e9eac82fc16723a1549e15bdaf370063572052a6I've also made the further change to use
Object.fromEntriesinstead of reduce, as it's the more modern approach imo, and typescript has better inference when using it (as, it caught a type issue)