-
Notifications
You must be signed in to change notification settings - Fork 541
A few tweaks #26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
A few tweaks #26
Conversation
|
Thanks for the pull. This project is abandoned. If you're still using this, I'm definitely open to sharing collaborator and npm rights. Also, this pull request doesn't merge, even before I merged the incoming pull requests. |
|
Definitely interested in collaborating on this module. Still using it after almost a year and would like to contribute. Let me know if I need to do a clean fork to complete the merge. |
|
A clean fork would be best. It's best to do your changes in a separate branch and keep master consistent with the source of the fork. One way you can quickly resolve this is by renaming your master, and creating a new master based on the fork. If you only have a Git remote for your fork, then you can add one for mine with: I wouldn't try merging your commit in, necessarily. It doesn't look like a all the commits are necessary. For instance, the sys reference was removed because I don't even use it anymore in the parser. I've given you collaborator rights on this repository. Enjoy :) |
|
Thanks for all those instructions. I'll have to decide I guess if I want to maintain a fork or a branch in your repo - but most likely not both. You mentioned that the project is not active and that's why I volunteered. Don't want to want to push the project in a direction you don't agree to. And keeping a seperate branch in your repo may confuse other users. Cheers, |
|
Separate branches are preferable for forks. But since you have I try to follow Semantic Versioning as much as possible. But since |
|
That's cool - I appreciate it and will try to tiptoe as much as possible. Do you have some service hook for updating the module on npmjs or should I just ask you to deploy? Cheers |
|
@tracend Did you ever open a fork for this? |
|
This is a year old issue and my memory is vague on the specifics. There's still a fork available but I cannot guarantee its condition at this point. I know that at the time, I updated this module for emotiglobe but it has since been using ntwitter... |
Recently I had to update the call of the sys lid to util so it would be published in Nodejitsu.
Please review the commits and let me know if you want to discuss further.