Skip to content

Conversation

@tracend
Copy link
Collaborator

@tracend tracend commented Apr 7, 2012

Recently I had to update the call of the sys lid to util so it would be published in Nodejitsu.

Please review the commits and let me know if you want to discuss further.

@technoweenie
Copy link
Owner

Thanks for the pull. This project is abandoned. If you're still using this, I'm definitely open to sharing collaborator and npm rights.

Also, this pull request doesn't merge, even before I merged the incoming pull requests.

@tracend
Copy link
Collaborator Author

tracend commented Apr 11, 2012

Definitely interested in collaborating on this module.

Still using it after almost a year and would like to contribute.

Let me know if I need to do a clean fork to complete the merge.

@technoweenie
Copy link
Owner

A clean fork would be best. It's best to do your changes in a separate branch and keep master consistent with the source of the fork. One way you can quickly resolve this is by renaming your master, and creating a new master based on the fork.

If you only have a Git remote for your fork, then you can add one for mine with:

git remote add technoweenie https://github.com/technoweenie/twitter-node
# assume we're on your modified master with no pending changes
git checkout master
git checkout -b tracend # create a new branch
git branch -D master
git checkout -t technoweenie/master # assumes 'technoweenie' is the name of the remote

I wouldn't try merging your commit in, necessarily. It doesn't look like a all the commits are necessary. For instance, the sys reference was removed because I don't even use it anymore in the parser.

I've given you collaborator rights on this repository. Enjoy :)

@tracend
Copy link
Collaborator Author

tracend commented Apr 11, 2012

Thanks for all those instructions.

I'll have to decide I guess if I want to maintain a fork or a branch in your repo - but most likely not both.

You mentioned that the project is not active and that's why I volunteered. Don't want to want to push the project in a direction you don't agree to. And keeping a seperate branch in your repo may confuse other users.

Cheers,
Makis

@technoweenie
Copy link
Owner

Separate branches are preferable for forks. But since you have
collaborator access, feel free to continue dev in master on the
source. My directions were mostly for you to get the changes in your
fork cherry-picked into master so you can push that, and delete your
fork.

I try to follow Semantic Versioning as much as possible. But since
twitter-node is mostly abandoned, you pretty much have free reign to
do what you want.

@tracend
Copy link
Collaborator Author

tracend commented Apr 12, 2012

That's cool - I appreciate it and will try to tiptoe as much as possible.

Do you have some service hook for updating the module on npmjs or should I just ask you to deploy?

Cheers

@chadcallahan
Copy link

@tracend Did you ever open a fork for this?

@tracend
Copy link
Collaborator Author

tracend commented Mar 4, 2013

This is a year old issue and my memory is vague on the specifics. There's still a fork available but I cannot guarantee its condition at this point.

I know that at the time, I updated this module for emotiglobe but it has since been using ntwitter...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants