fix: fixed issue where requesting through s throws an error#156
Open
AL-Hareth wants to merge 1 commit intotechtanic:masterfrom
Open
fix: fixed issue where requesting through s throws an error#156AL-Hareth wants to merge 1 commit intotechtanic:masterfrom
AL-Hareth wants to merge 1 commit intotechtanic:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
the problem previously was that you were passing session as a named variable with the wrong name like this:
but if we look at the signature of the create_scraper function we find that it looks like this
so to fix this problem we can either pass the session anonymously like what i did in the pull request or we can use the proper name of the argument
or
And I renamed the variable just to keep the old variable because mutating it can be bad in some cases