-
Notifications
You must be signed in to change notification settings - Fork 169
UI Refresh with updated dependencies #126
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@alvi-khan Hi, when you get some free time, can you kindly review this one? P.S: Desktop artifacts can be downloaded from the "Checks" > "Summary" |
|
Hey @tecoholic. The UI updates look great! I added a few minor opinions I had above. Two more things. Firstly, I guess the link under the Secondly, I think the windows build is failing because of the version number. It seems this is a known issue. I guess we'll have to manually upload the windows builds to the releases section until this version is ready for a full release. |
|
@alvi-khan Thank you for a detailed review. I fixed a number of issues you pointed out and also made a few adjustments to the start page, including disabling the menu items on start page - only "Open File" is allowed.
|
|
|
@alvi-khan I generally agree with your comments on colors. Would you be kind enough to update the PR with the colors you think would be appropriate? I am generally color challenged and that's the reason, I tend to stick to defaults for most things. I tried to communicate certain things with color, but seems to have failed terribly 🫨 I have access to Macs both Intel and ARM ones. So, I can test the builds. No worries. |
|
@tecoholic Hey, I struggle with colors too — it's tricky! And you're being way too hard on yourself. The UI you built, both before and in this update, looks amazing! The modern and user-friendly design you gave this app is a big reason I decided to use it in the first place. I’ve made a few minor adjustments to the colors where I thought it might help. If you’re good with these changes, I think this is ready to be merged. Thanks so much for putting in all this effort — it really shows! |
|
@alvi-khan Thanks for your kind words and taking the time to make the fixes. You have been a great support in maintaining this project. Version 2.0.0 released :) |
Duplication of #125 after the diff got messed up for some reason.
This is based on #122 adding a bit more clean up and polish to the UI.
Before
After