Closed
Conversation
Owner
|
Thanks for this work! I've recently started the long-promised rewrite though, so I'm afraid the code you've made this PR against will be gone in the next version of the package 😅 |
Contributor
Author
|
Thanks. I am going to close this then. Did not know about the rewrite. If you'd like, I'd love to contribute to the test suite. Writing unit tests is how I achieve zen. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The main purpose of this PR is to add some unit tests. Not a lot (~8% coverage). Along the way, I discovered a couple of bugs.
Firstly, nested inline markup did not parse as expected. Evaluating
parsetree(org"*/text/*")returned the following:It now returns the following:
Secondly, the
TextMarkup(::Symbol,::String)constructor was functionally broken. Granted, this constructor isn't documented.