feat: add permissions_boundary support for IAM role

[posquit0]

Summary

This PR adds permissions_boundary parameter support to IAM roles in modules that use the terraform-aws-account iam-role module. This allows users to configure IAM permissions boundaries for better security control.

Changes

modules/sfn-state-machine

• iam.tf: Added permissions_boundary parameter to module "role"
• variables.tf: Added permissions_boundary = optional(string) to iam_role variable

Reference

This change follows the pattern established in: tedilabs/terraform-aws-security@a653680

[github-actions]

👋 Welcome! Looks like this is your first pull request.

Hey, thanks for your contribution! Please give us a bit of time to review it. 😄

Please check out our contributing guidelines.

[gemini-code-assist]

Summary of Changes

Hello @posquit0, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request enhances the iam-role module within the terraform-aws-account by adding support for IAM permissions boundaries. This allows users to enforce stricter security controls on the created IAM roles by limiting the maximum permissions that the role can have.

Highlights

• IAM Permissions Boundary Support: This PR introduces the ability to set a permissions boundary for IAM roles created using the terraform-aws-account iam-role module.
• Configuration via Variable: The permissions_boundary is configured via an optional parameter in the iam_role variable.
• Module Update: The sfn-state-machine module is updated to include the new permissions_boundary parameter in the IAM role configuration.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Changelog

• modules/sfn-state-machine/iam.tf
  • Added permissions_boundary parameter to the module "role" block.
• modules/sfn-state-machine/variables.tf
  • Added permissions_boundary optional string to the iam_role variable definition.

Activity

• The PR adds a new feature to an existing module.
• The changes include modifications to iam.tf and variables.tf in the sfn-state-machine module.
• The PR description references a commit in another repository as a pattern for the changes.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request adds support for permissions_boundary to the IAM role in the sfn-state-machine module. The implementation is straightforward, adding an optional permissions_boundary attribute to the iam_role variable and passing it to the underlying iam-role module. My review includes one point of feedback regarding the need to update the module's README.md documentation to reflect this new parameter, ensuring it remains accurate for users.

[gemini-code-assist]

The README.md file, which contains the module's documentation, has not been updated to reflect the addition of the permissions_boundary attribute to the iam_role variable. Please regenerate the documentation to ensure it stays in sync with the code, as this is crucial for module usability.