Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This pull request aims to simplify configuration by removing environment variables that users don't need to configure directly. The changes focus on hardcoding internal Docker container names and removing deploy-time configuration that isn't actually used.
Changes:
- Hardcode CLIENT_ADDRESS and VITE_SERVER_ADDRESS to use Docker container names directly
- Remove these variables from the example configuration file
- Update nginx configuration to use a catch-all server_name instead of VITE_BUDGET_BOARD_DOMAIN
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| compose.yml | Hardcodes CLIENT_ADDRESS and VITE_SERVER_ADDRESS environment variables with Docker container names |
| compose.env | Removes BUDGET_BOARD_DOMAIN, SERVER_ADDRESS, and CLIENT_ADDRESS from example configuration |
| client/.docker/nginx/conf/default.conf.template | Changes nginx server_name from VITE_BUDGET_BOARD_DOMAIN variable to catch-all underscore |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
teelur
added a commit
that referenced
this pull request
Jan 10, 2026
* remove unused config options * remove trailing slash * remove unused domain * fix
teelur
added a commit
that referenced
this pull request
Jan 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CLIENT_ADDRESSandSERVER_ADDRESSenv variables as they are not something a user needs to configureBUDGET_BOARD_DOMAINenv variable because it is not used at deploy time