Skip to content

Re-enable prepare/shell test with mock provisioning#4701

Open
mkoncek wants to merge 1 commit intoteemtee:mainfrom
mkoncek:mock-shell-test
Open

Re-enable prepare/shell test with mock provisioning#4701
mkoncek wants to merge 1 commit intoteemtee:mainfrom
mkoncek:mock-shell-test

Conversation

@mkoncek
Copy link
Collaborator

@mkoncek mkoncek commented Mar 16, 2026

Pull Request Checklist

  • implement the feature
  • write the documentation
  • extend the test coverage
  • update the specification
  • adjust plugin docstring
  • modify the json schema
  • mention the version
  • include a release note

@mkoncek mkoncek added step | provision Stuff related to the provision step plugin | mock Related to mock provision plugin labels Mar 16, 2026
@mkoncek mkoncek mentioned this pull request Mar 16, 2026
Open
8 tasks
gemini-code-assist[bot]
gemini-code-assist bot reviewed Mar 16, 2026
View reviewed changes
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request re-enables the prepare/shell test for mock provisioning. The change in tests/prepare/shell/main.fmf activates the provision-mock tag for the test, removing the previous TODO that disabled it.

@LecrisUT LecrisUT added the ci | full test Pull request is ready for the full test execution label Mar 16, 2026
@thrix thrix self-requested a review March 16, 2026 13:35
@LecrisUT
Copy link
Member

LecrisUT commented Mar 16, 2026

/packit test

@LecrisUT
Copy link
Member

LecrisUT commented Mar 16, 2026

@mkoncek test failure is now available to inspect in fedora-44:full

@mkoncek
Copy link
Collaborator Author

mkoncek commented Mar 16, 2026

I have a hard time seeing what is wrong there.
Nevertheless, I believe mock should not be invoked as root.

@happz happz added this to planning Mar 18, 2026
@github-project-automation github-project-automation bot moved this to backlog in planning Mar 18, 2026
@happz happz moved this from backlog to implement in planning Mar 18, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@thrix thrix Awaiting requested review from thrix

1 more reviewer

@gemini-code-assist gemini-code-assist[bot] gemini-code-assist[bot] left review comments

Reviewers whose approvals may not affect merge requirements

At least 2 approving reviews are required to merge this pull request.

Assignees

No one assigned

Labels

ci | full test Pull request is ready for the full test execution plugin | mock Related to mock provision plugin step | provision Stuff related to the provision step

Projects

planning
Status: implement

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@mkoncek @LecrisUT @happz