Conversation
Contributor
There was a problem hiding this comment.
Code Review
This pull request adds documentation for user tree, work tree, and test tree concepts. The review identifies several areas for improvement to enhance clarity and correctness. Key issues include inconsistent example paths, conversational phrasing that violates the style guide, and factual inaccuracies in the description of which tree is used at different stages of a tmt run. Applying the suggested changes will make the documentation more precise and easier for contributors to understand.
mcasquer
reviewed
Mar 17, 2026
mcasquer
reviewed
Mar 17, 2026
81d0b4d to
ac7d917
Compare
happz
reviewed
Mar 17, 2026
happz
reviewed
Mar 17, 2026
happz
reviewed
Mar 17, 2026
happz
reviewed
Mar 17, 2026
happz
reviewed
Mar 17, 2026
8fbcc3c to
02ffd28
Compare
LecrisUT
reviewed
Mar 18, 2026
2e2bd44 to
cf6e1c6
Compare
LecrisUT
approved these changes
Mar 19, 2026
Define `user tree`, `work tree` and `test tree`. Document `run workdir` and `plan workdir` as well. Add the `Tree Handling` section for contributors. Fix #4663.
cf6e1c6 to
984ea9d
Compare
Member
Author
|
Documentation change, core tests passed, merging. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Define
user tree,work treeandtest tree.Document
run workdirandplan workdiras well.Add the
Tree Handlingsection for contributors.Fix #4663.
Pull Request Checklist