Add additional conversion methods to step & guest dataclasses#4727
Open
Add additional conversion methods to step & guest dataclasses#4727
Conversation
therazix
added
ci | full test
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This PR introduces new to_spec and to_minimal_spec methods to several dataclasses within the tmt library, enhancing data serialization capabilities. It also fixes issues related to object representation during conversion. The changes include adding methods to GuestSshData, DiscoverFmfStepData, and other classes, along with necessary imports and adjustments to handle different data types and structures. Review comments have been provided focusing on potential efficiency and readability improvements in data transformation logic.
8 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR changes some
to_spec/to_minimal_specconversion methods in the step and guest dataclasses and also adds additional ones that were missing. Steps should now be correctly converted, and it should get rid ofcannot represent an objecterrors.Blocks: #4661
Pull Request Checklist