Address feedback from PR #241 #244
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
neuroevolutus
had a problem deploying
to
scrapscript-pr-244
GitHub Actions
Failure
tekknolagi
approved these changes
Feb 26, 2025
scrapscript.py
Outdated
| result.source_extent.end.byteno = self.current_token_source_extent.end.byteno | ||
|
|
||
| return result | ||
| return make_source_annotated_token(cls, copy.deepcopy(self.current_token_source_extent), *args) |
Owner
There was a problem hiding this comment.
I think if you use dataclasses, you get a copy for free. Try calling .replace() (no arguments)
Contributor
Author
There was a problem hiding this comment.
Thanks for the suggestion; actually, it seems that replace is a free-standing function defined in module dataclasses, so I had to do replace(self.current_token_source_extent). However, this failed the tests since it did not seem to do a deep copy of the dataclass fields.
scrapscript_tests.py
Outdated
| int_ast = make_source_annotated_object(Int, source_extent, 1) | ||
| self.assertTrue(parse(Peekable(iter([int_lit]))).source_extent == int_ast.source_extent) | ||
| int_lit = make_source_annotated_token(IntLit, source_extent, 1) | ||
| self.assertTrue(parse(Peekable(iter([int_lit]))).source_extent == source_extent) |
Owner
There was a problem hiding this comment.
assertEqual, please (here and everywhere)
Owner
|
You may also find it useful to convert |
neuroevolutus
had a problem deploying
to
scrapscript-pr-244
GitHub Actions
Failure
neuroevolutus
had a problem deploying
to
scrapscript-pr-244
GitHub Actions
Failure
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I added a function called
make_source_annotated_tokento simplify the repeated logic in the source extent tests, but if it's unnecessary I can easily revert those commits.Edit: Linking the PR for easy, future reference: #241.