Skip to content

docker-build: add docker readiness check and update builder image#1365

Draft
szuo-hv wants to merge 1 commit intotektoncd:mainfrom
szuo-hv:issue-628
Draft

docker-build: add docker readiness check and update builder image#1365
szuo-hv wants to merge 1 commit intotektoncd:mainfrom
szuo-hv:issue-628

Conversation

@szuo-hv
Copy link

@szuo-hv szuo-hv commented Feb 26, 2026

Changes

Summary
Adds a bounded docker-info readiness step to avoid indefinite hangs when the DinD daemon is not ready, and updates the default builder_image to Docker 29 (linux/amd64, digest‑pinned).

Details

  • New docker-info step retries docker info up to 60 times with clear failure output.
  • builder_image bumped to:
    docker.io/library/docker@sha256:2658fda9e8779b94ea1581f4d25214dac9ed144b407902842e5328cce8f861f5
  • No user‑facing parameters changed.

Fixes #628

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

  • Follows the authoring recommendations
  • Includes docs (if user facing)
    This change is internal to the task steps and does not require documentation updates.
  • Includes tests (for new tasks or changed functionality)
    This change is internal to the task steps. No additional e2e test needed.
  • Meets the Tekton contributor standards (including functionality, content, code)
  • Commit messages follow commit message best practices
  • Has a kind label. You can add one by adding a comment on this PR that
    contains /kind <type>. Valid types are bug, cleanup, design, documentation,
    feature, flake, misc, question, tep
  • Complies with Catalog Organization TEP, see example. Note An issue has been filed to automate this validation
    • File path follows <kind>/<name>/<version>/name.yaml

    • Has README.md at <kind>/<name>/<version>/README.md

    • Has mandatory metadata.labels - app.kubernetes.io/version the same as the <version> of the resource

    • Has mandatory metadata.annotations tekton.dev/pipelines.minVersion

    • mandatory spec.description follows the convention

        ```
      
        spec:
          description: >-
            one line summary of the resource
      
            Paragraph(s) to describe the resource.
        ```
      

See the contribution guide for more details.

@tekton-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please assign vdemeester after the PR has been reviewed.
You can assign the PR to them by writing /assign @vdemeester in a comment when ready.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Feb 26, 2026
@linux-foundation-easycla
Copy link

CLA Not Signed

@tekton-robot tekton-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Feb 26, 2026
@szuo-hv
Copy link
Author

szuo-hv commented Feb 26, 2026

/kind bug

@tekton-robot tekton-robot added the kind/bug Categorizes issue or PR as related to a bug. label Feb 26, 2026
@tekton-robot
Copy link

Catlin Output
FILE: task/docker-build/0.1/docker-build.yaml
WARN : Step "docker-info" uses image "$(params.builder_image)" that contains variables; skipping validation
WARN : Step "docker-build" uses image "$(params.builder_image)" that contains variables; skipping validation
WARN : Step "docker-push" uses image "$(params.builder_image)" that contains variables; skipping validation
Catlin script lint Output
WARN : step: docker-build is not using #!/usr/bin/env 
ERROR: /usr/bin/shellcheck, [-s sh] failed:

In docker-build-docker-build line 3:
  $(params.build_extra_args) \
  ^------------------------^ SC2046 (warning): Quote this to prevent word splitting.


In docker-build-docker-build line 5:
  -f $(params.dockerfile) -t $(params.image) $(params.context)
     ^------------------^ SC2046 (warning): Quote this to prevent word splitting.
                             ^-------------^ SC2046 (warning): Quote this to prevent word splitting.
                                             ^---------------^ SC2046 (warning): Quote this to prevent word splitting.

For more information:
  https://www.shellcheck.net/wiki/SC2046 -- Quote this to prevent word splitt...

ERROR: /usr/bin/shellcheck, [-s sh] failed:

In docker-build-docker-push line 2:
docker push $(params.push_extra_args) $(params.image)
            ^-----------------------^ SC2046 (warning): Quote this to prevent word splitting.
                                      ^-------------^ SC2046 (warning): Quote this to prevent word splitting.

For more information:
  https://www.shellcheck.net/wiki/SC2046 -- Quote this to prevent word splitt...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. kind/bug Categorizes issue or PR as related to a bug. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Trying to run task docker-build

2 participants