docker-build: add docker readiness check and update builder image#1365
Draft
szuo-hv wants to merge 1 commit intotektoncd:mainfrom
Draft
docker-build: add docker readiness check and update builder image#1365szuo-hv wants to merge 1 commit intotektoncd:mainfrom
szuo-hv wants to merge 1 commit intotektoncd:mainfrom
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
Author
|
/kind bug |
Catlin OutputCatlin script lint Output |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Summary
Adds a bounded
docker-inforeadiness step to avoid indefinite hangs when the DinD daemon is not ready, and updates the defaultbuilder_imageto Docker 29 (linux/amd64, digest‑pinned).Details
docker-infostep retries docker info up to 60 times with clear failure output.builder_imagebumped to:docker.io/library/docker@sha256:2658fda9e8779b94ea1581f4d25214dac9ed144b407902842e5328cce8f861f5Fixes #628
Submitter Checklist
These are the criteria that every PR should meet, please check them off as you
review them:
This change is internal to the task steps and does not require documentation updates.
This change is internal to the task steps. No additional e2e test needed.
contains
/kind <type>. Valid types are bug, cleanup, design, documentation,feature, flake, misc, question, tep
File path follows
<kind>/<name>/<version>/name.yamlHas
README.mdat<kind>/<name>/<version>/README.mdHas mandatory
metadata.labels-app.kubernetes.io/versionthe same as the<version>of the resourceHas mandatory
metadata.annotationstekton.dev/pipelines.minVersionmandatory
spec.descriptionfollows the conventionSee the contribution guide for more details.