-
Notifications
You must be signed in to change notification settings - Fork 262
Update README and choco with latest release #2666
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
divyansh42
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, @pratap0007 for doing the refactoring. Changes look good!
Just a minor comment.
README.md
Outdated
| input](<https://en.wikipedia.org/wiki/Standard_streams#Standard_input_(stdin)>) | ||
| attached. If you pipe the tkn command or run it in a non interactive way (ie: | ||
| from tekton itself in a Task) the coloring and emojis will *always* be disabled. | ||
| from tekton itself in a Task) the coloring and emojis will _always_ be disabled. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit:
We may want to keep it in bold letters only.
Signed-off-by: Shiv Verma <[email protected]>
Signed-off-by: Shiv Verma <[email protected]>
149667e to
01515de
Compare
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: vinamra28 The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/lgtm |
Changes
Submitter Checklist
These are the criteria that every PR should meet, please check them off as you
review them:
make checkmake generatedSee the contribution guide
for more details.
Release Notes