Skip to content

Add TektonResult to TektonConfig doc #2400

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
tekton-robot merged 1 commit into from
Mar 14, 2025
Merged

Add TektonResult to TektonConfig doc #2400

tekton-robot merged 1 commit into from
Mar 14, 2025

Conversation

@pratap0007
Copy link
Contributor

@pratap0007 pratap0007 commented Nov 11, 2024 •
edited
Loading

Changes

This will add the instructions in TektonConfig doc how to install and manage
Results component through TektonConfig doc and updates TektonResult doc

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

See the contribution guide for more details.

Release Notes

Add instructions to install and manage  Tekton Results through Tekton Config

@tekton-robot tekton-robot added the release-note Denotes a PR that will be considered when it comes time to generate release notes. label Nov 11, 2024
@tekton-robot tekton-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Nov 11, 2024
@pratap0007 pratap0007 mentioned this pull request Nov 11, 2024
Merged
4 tasks
jkandasa
jkandasa reviewed Nov 19, 2024
View reviewed changes
docs/TektonConfig.md
result:
disabled: false
is_external_db: false
options: {}
Copy link
Member

@jkandasa jkandasa Nov 19, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pratap0007 still the results is not part for TektonConfig CRD

jkandasa
jkandasa reviewed Nov 19, 2024
View reviewed changes
Copy link
Member

@jkandasa jkandasa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR @pratap0007,
however the results is not part of the TektonConfig CRD, if you are working on the implementation, please update this doc changes on the implementation PR.

@pratap0007 pratap0007 force-pushed the update-result-docs branch 2 times, most recently from 017ac5a to 0225862 Compare November 25, 2024 08:09
@pratap0007 pratap0007 changed the title Update TektonResult docs Add TektonResult to TektonConfig doc Nov 25, 2024
@tekton-robot tekton-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Dec 16, 2024
khrm
khrm reviewed Jan 15, 2025
View reviewed changes
docs/TektonConfig.md
Result section allows user to customize the Tekton Result component, Refer to [Result Spec](https://github.com/tektoncd/operator/blob/main/docs/TektonResult.md#spec) section in TektonResult for available options.
Example:
Copy link
Contributor

@khrm khrm Jan 15, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we mention what's the default when no values are specified?

Copy link
Member

@jkhelil jkhelil Jan 31, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pratap0007 ^^^

Copy link
Contributor Author

@pratap0007 pratap0007 Feb 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@khrm updated and please review once again

@pratap0007 pratap0007 force-pushed the update-result-docs branch 2 times, most recently from 7bb8836 to 2106dea Compare January 29, 2025 05:06
@pratap0007
Copy link
Contributor Author

pratap0007 commented Feb 3, 2025

/retest

@pratap0007
Copy link
Contributor Author

pratap0007 commented Feb 3, 2025

/restest

jkhelil
jkhelil reviewed Feb 4, 2025
View reviewed changes
@pratap0007
Copy link
Contributor Author

pratap0007 commented Feb 5, 2025

/retest

@pratap0007 pratap0007 force-pushed the update-result-docs branch 2 times, most recently from 03bd2eb to 6c9d8c7 Compare February 11, 2025 04:56
@rupalibehera
Copy link
Member

rupalibehera commented Feb 11, 2025

is it good to be merged ?

@pratap0007
Copy link
Contributor Author

pratap0007 commented Feb 11, 2025

is it good to be merged ?

yes, it is good to merge cc: @khrm @savitaashture

@l-qing
Copy link
Member

l-qing commented Feb 18, 2025

It seems that this PR needs to be rebased.😆

l-qing
l-qing reviewed Feb 19, 2025
View reviewed changes
@pratap0007
Copy link
Contributor Author

pratap0007 commented Feb 19, 2025

/retest

1 similar comment
@l-qing
Copy link
Member

l-qing commented Feb 20, 2025

/retest

l-qing
l-qing approved these changes Feb 20, 2025
View reviewed changes
Copy link
Member

@l-qing l-qing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@tekton-robot
Copy link
Contributor

tekton-robot commented Feb 20, 2025

@l-qing: changing LGTM is restricted to collaborators

Details

In response to this:

/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@l-qing
Copy link
Member

l-qing commented Feb 20, 2025

/approve

@l-qing
Copy link
Member

l-qing commented Feb 20, 2025

/assign @piyush-garg

@l-qing
Copy link
Member

l-qing commented Feb 20, 2025

I'm not sure if the current GitHub Action can be retried. My previous approach was to push the branch again. For example: git commit --verbose --all --no-edit --amend

@l-qing
Copy link
Member

l-qing commented Feb 28, 2025

This feature #2398 has been merged before. It has also been included in the recently released version 0.75.0. But the document has not been merged.

@khrm Could someone help take a look?

@pratap0007
Add TektonResult to TektonConfig doc
a8b573b 
This will add the instructions in TektonConfig doc how to install and manage
Results component through Tekton Config TektonConfig doc and updates TektonResult doc

Signed-off-by: Shiv Verma <shverma@redhat.com>
@pratap0007 pratap0007 force-pushed the update-result-docs branch from 79375cd to a8b573b Compare March 6, 2025 05:00
khrm
khrm reviewed Mar 6, 2025
View reviewed changes
Copy link
Contributor

@khrm khrm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@jkhelil
Copy link
Member

jkhelil commented Mar 14, 2025

/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Mar 14, 2025
@jkhelil
Copy link
Member

jkhelil commented Mar 14, 2025

/approve

@tekton-robot
Copy link
Contributor

tekton-robot commented Mar 14, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jkhelil, khrm, l-qing

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 14, 2025
@tekton-robot tekton-robot merged commit e690834 into tektoncd:main Mar 14, 2025
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jkhelil jkhelil jkhelil left review comments

@piyush-garg piyush-garg Awaiting requested review from piyush-garg

@PuneetPunamiya PuneetPunamiya Awaiting requested review from PuneetPunamiya

+3 more reviewers

@khrm khrm khrm left review comments

@jkandasa jkandasa jkandasa left review comments

@l-qing l-qing l-qing approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@jkhelil jkhelil

@piyush-garg piyush-garg

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@pratap0007 @rupalibehera @l-qing @tekton-robot @jkhelil @khrm @jkandasa @piyush-garg