-
Notifications
You must be signed in to change notification settings - Fork 234
Add MultiCluster Scheduler config #3144
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
562e364 to
0bb5bac
Compare
savitaashture
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks you Pramod
Basic query:
Don't we need to add validation file i mean tektonscheduler_validation.go file where we need to consider the case of validating fields as well as if scheduler itself is disabled then there is no point in enabling MultiCluster
|
|
||
| // The version of the installed release | ||
| // +optional | ||
| Version string `json:"version,omitempty"` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does it refers operator version ??
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is component version
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
But we won't be having any version for MultiCluster isn;t it ??
If scheduler is disabled then status of multicluster does not matter. I think we can skip the validation as part of this PR as this is intended to unblock the other components. |
c7b8392 to
eee644c
Compare
| MultiClusterRole MultiClusterRole `json:"multi-cluster-role"` | ||
| } | ||
|
|
||
| type MultiClusterRole string |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
could you please add a comment here, if needed?
eee644c to
8040f38
Compare
Signed-off-by: Shubham Bhardwaj <[email protected]>
- hub: v1.23.5 → v1.23.6 - pipelines-as-code: v0.39.3 → v0.40.0 Signed-off-by: tekton-bot <[email protected]>
Signed-off-by: Pramod Bindal <[email protected]>
8040f38 to
7b3b157
Compare
Changes
This is enabling multicluster config from tektonconfig.
after these changes tektonconfig will look like this
Submitter Checklist
These are the criteria that every PR should meet, please check them off as you
review them:
make test lintbefore submitting a PRSee the contribution guide for more details.
Release Notes