Skip to content

Conversation

@pramodbindal
Copy link
Member

@pramodbindal pramodbindal commented Jan 7, 2026

Changes

This is enabling multicluster config from tektonconfig.

after these changes tektonconfig will look like this

scheduler:
      disabled: true
      multi-cluster-enabled: false
      multi-cluster-role: ""
      options: {}
 

Submitter Checklist

These are the criteria that every PR should meet, please check them off as you
review them:

See the contribution guide for more details.

Release Notes

NONE

@tekton-robot tekton-robot added the release-note-none Denotes a PR that doesnt merit a release note. label Jan 7, 2026
@tekton-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please assign jkhelil after the PR has been reviewed.
You can assign the PR to them by writing /assign @jkhelil in a comment when ready.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Jan 7, 2026
Copy link
Contributor

@savitaashture savitaashture left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks you Pramod

Basic query:
Don't we need to add validation file i mean tektonscheduler_validation.go file where we need to consider the case of validating fields as well as if scheduler itself is disabled then there is no point in enabling MultiCluster


// The version of the installed release
// +optional
Version string `json:"version,omitempty"`
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does it refers operator version ??

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is component version

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But we won't be having any version for MultiCluster isn;t it ??

@pramodbindal
Copy link
Member Author

Thanks you Pramod

Basic query: Don't we need to add validation file i mean tektonscheduler_validation.go file where we need to consider the case of validating fields as well as if scheduler itself is disabled then there is no point in enabling MultiCluster

If scheduler is disabled then status of multicluster does not matter.

I think we can skip the validation as part of this PR as this is intended to unblock the other components.

@pramodbindal pramodbindal force-pushed the multi-cluster branch 2 times, most recently from c7b8392 to eee644c Compare January 9, 2026 10:54
MultiClusterRole MultiClusterRole `json:"multi-cluster-role"`
}

type MultiClusterRole string
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could you please add a comment here, if needed?

@tekton-robot tekton-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 12, 2026
infernus01 and others added 3 commits January 12, 2026 10:57
- hub: v1.23.5 → v1.23.6
- pipelines-as-code: v0.39.3 → v0.40.0

Signed-off-by: tekton-bot <[email protected]>
@tekton-robot tekton-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jan 12, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

release-note-none Denotes a PR that doesnt merit a release note. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants