Skip to content

Conversation

@vdemeester
Copy link
Member

@vdemeester vdemeester commented Jan 9, 2026

Changes

This PR cleans up the bump component workflows to prevent temporary files from being committed to the repository.

Changes made:

  • Removed bump-output.txt from git tracking (it was previously committed)
  • Added cleanup step in both bump workflows to remove temporary files before PR creation
  • Applies to both bump-payload-on-main.yaml and bump-payload-on-releases.yaml

The workflows now clean up these temporary files before the create-pull-request action runs:

  • bump-output.txt
  • commit-message.txt
  • pr-body.txt

Submitter Checklist

  • Run make test lint before submitting a PR
  • Includes tests (if functionality changed/added) - N/A for workflow changes
  • Includes docs (if user facing) - N/A for internal workflow changes
  • Commit messages follow commit message best practices

See the contribution guide for more details.

Release Notes

NONE

- Add cleanup step to remove bump-output.txt before PR creation
- Prevent temporary files from being committed by automation
- Apply to both main and release branch workflows
- Remove bump-output.txt from the repository

Signed-off-by: Vincent Demeester <[email protected]>
@tekton-robot tekton-robot added do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. release-note-none Denotes a PR that doesnt merit a release note. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Jan 9, 2026
@pratap0007
Copy link
Contributor

/lgtm

@tekton-robot tekton-robot added the lgtm Indicates that a PR is ready to be merged. label Jan 12, 2026
@jkhelil
Copy link
Member

jkhelil commented Jan 12, 2026

/approve

@tekton-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jkhelil

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jan 12, 2026
@tekton-robot tekton-robot merged commit c8d5e4f into tektoncd:main Jan 12, 2026
13 checks passed
@vdemeester vdemeester deleted the fix/remove-bump-output-from-git branch January 12, 2026 11:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. lgtm Indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesnt merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants