fix: remove release-right-meow SA from PAC release PipelineRuns#3336
Merged
tekton-robot merged 1 commit intotektoncd:mainfrom Apr 8, 2026
Merged
fix: remove release-right-meow SA from PAC release PipelineRuns#3336tekton-robot merged 1 commit intotektoncd:mainfrom
tekton-robot merged 1 commit intotektoncd:mainfrom
Conversation
|
Caution There are some errors in your PipelineRun template.
|
tekton-robot
added
kind/bug
tekton-robot
added
the
size/XS
Member
|
/approve |
Contributor
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jkhelil The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
tekton-robot
added
the
approved
Fix the on-cel-expression to use the correct CEL variables:
- Use 'event' and 'target_branch' (not 'pac.target_branch' which is
only available in {{ cel: }} param substitution, not in
on-cel-expression matching)
- Use 'target_branch' without 'refs/heads/' prefix (PAC strips it)
- Use '|' literal block scalar instead of '>' folding to avoid
trailing newline issues
- Add 'event == "push"' for explicitness
Also remove the release-right-meow ServiceAccount from both
PipelineRuns. It is a leftover from the old EventListener-based
release flow. All release secrets are mounted as workspaces, so
the default SA is sufficient.
vdemeester
force-pushed
the
remove-release-sa
branch
from
eb386b1 to
e072898
Compare
tekton-robot
added
size/S
Member
|
/lgtm |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Remove the
release-right-meowServiceAccount from the PAC releasePipelineRuns (
.tekton/release.yamland.tekton/release-patch.yaml).This SA is a leftover from the old EventListener-based release flow on
the GKE cluster. On the Oracle cluster, all release secrets (OCI bucket,
GHCR, GitHub token) are mounted as workspaces directly in the
PipelineRun, so no special SA permissions are needed. The default
ServiceAccount in the
releases-operatornamespace is sufficient.Without this fix, release PipelineRuns fail at the first task with:
Submitter Checklist
These are the criteria that every PR should meet, please check them off as you
review them:
make test lintbefore submitting a PRSee the contribution guide for more details.
Release Notes
/kind bug