Skip to content

[TEP-0056]: Fix typos and remove skipped e2e tests. #8874

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

[TEP-0056]: Fix typos and remove skipped e2e tests. #8874

wants to merge 1 commit into from
+13 −209

Conversation

twoGiants
Copy link
Member

Changes

Remove unused code and helper functions from PipelineRun e2e tests.

Fix typos premption => preemption.

Issues #8760, #7166.

/kind cleanup

Submitter Checklist

As the author of this PR, please check off the items in this checklist:

  • Has Docs if any changes are user facing, including updates to minimum requirements e.g. Kubernetes version bumps
  • Has Tests included if any functionality added or changed
  • pre-commit Passed
  • Follows the commit message standard
  • Meets the Tekton contributor standards (including functionality, content, code)
  • Has a kind label. You can add one by adding a comment on this PR that contains /kind <type>. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tep
  • Release notes block below has been updated with any user facing changes (API changes, bug fixes, changes requiring upgrade notices or deprecation warnings). See some examples of good release notes.
  • Release notes contains the string "action required" if the change requires additional action from users switching to the new release

Release Notes

NONE

@tekton-robot tekton-robot added kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. release-note-none Denotes a PR that doesnt merit a release note. labels Jul 11, 2025
@tekton-robot tekton-robot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jul 11, 2025
@twoGiants
Copy link
Member Author

/test check-pr-has-kind-label

@tekton-robot
Copy link
Collaborator

@twoGiants: No presubmit jobs available for tektoncd/pipeline@main

In response to this:

/test check-pr-has-kind-label

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@twoGiants twoGiants mentioned this pull request Jul 12, 2025
Open
31 tasks
@vdemeester
Copy link
Member

Might need a rebase 🙃

@tekton-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: vdemeester

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot tekton-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 30, 2025
@twoGiants twoGiants force-pushed the issue-8760-tep-0056-fix-typos-remove-skipped-tests branch from ee01b5a to 2ea4ecb Compare July 30, 2025 16:37
@twoGiants
refactor: remove skipped e2e testcases
1e8203e 
Remove unused code and helper functions from PipelineRun e2e tests.

Fix typos premption => preemption.

Issues tektoncd#8760, tektoncd#7166.

Signed-off-by: Stanislav Jakuschevskij <[email protected]>
@twoGiants twoGiants force-pushed the issue-8760-tep-0056-fix-typos-remove-skipped-tests branch from 2ea4ecb to 1e8203e Compare July 30, 2025 16:55
afrittoli
afrittoli reviewed Jul 30, 2025
View reviewed changes
test/pipelinerun_test.go
@@ -201,97 +199,6 @@ func TestPipelineRun(t *testing.T) {
expectedTaskRuns: []string{"create-file-kritis", "create-fan-out-1", "create-fan-out-2", "check-fan-in"},
// 1 from PipelineRun and 4 from Tasks defined in pipelinerun
expectedNumberOfEvents: 5,
}, {
name: "service account propagation and pipeline param",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uhm, I think these tests were removed because they relied on build-crd-testing, which was removed (whatever it was?), but the functionality that was being tested on Tekton side has not been removed, so perhaps a better option would be to rewrite them they don't need build-crd-testing anymore?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point, thank you. Will do!

@waveywaves
Copy link
Member

/retest

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@afrittoli afrittoli afrittoli left review comments

@vdemeester vdemeester vdemeester approved these changes

@dibyom dibyom Awaiting requested review from dibyom

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. release-note-none Denotes a PR that doesnt merit a release note. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
Tekton Community Roadmap
Status: Todo
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@twoGiants @tekton-robot @vdemeester @waveywaves @afrittoli