Skip to content

Conversation

twoGiants
Copy link
Member

Important

Pull request number 2.
The numbering Nr. 2 - [TEP-0056] means the PRs must be merged in order. They build on each other.

Changes

[TEP-0056]: Second PR of Pipelines-in-Pipelines feature implementation.

Extend existing methods in pipelinerunstate.go to check for child PipelirRuns and add new test cases.

Issue #8760, #7166.

Release notes will be added with the last PR which will make this feature functional for users.

/kind feature

Submitter Checklist

As the author of this PR, please check off the items in this checklist:

  • Has Docs if any changes are user facing, including updates to minimum requirements e.g. Kubernetes version bumps
  • Has Tests included if any functionality added or changed
  • pre-commit Passed
  • Follows the commit message standard
  • Meets the Tekton contributor standards (including functionality, content, code)
  • Has a kind label. You can add one by adding a comment on this PR that contains /kind <type>. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tep
  • Release notes block below has been updated with any user facing changes (API changes, bug fixes, changes requiring upgrade notices or deprecation warnings). See some examples of good release notes.
  • Release notes contains the string "action required" if the change requires additional action from users switching to the new release

Release Notes

NONE

@tekton-robot tekton-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. release-note-none Denotes a PR that doesnt merit a release note. kind/feature Categorizes issue or PR as related to a new feature. labels Jul 12, 2025
@tekton-robot tekton-robot added the size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. label Jul 12, 2025
@tekton-robot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please assign waveywaves after the PR has been reviewed.
You can assign the PR to them by writing /assign @waveywaves in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@tekton-robot
Copy link
Collaborator

The following is the coverage report on the affected files.
Say /test pull-tekton-pipeline-go-coverage-df to re-run this coverage report

File Old Coverage New Coverage Delta
pkg/apis/pipeline/v1/pipelinerun_types.go 92.5% 92.6% 0.1
pkg/reconciler/pipelinerun/pipelinerun.go 91.6% 91.5% -0.1
pkg/reconciler/pipelinerun/resources/pipelinerunresolution.go 96.5% 96.0% -0.5
pkg/reconciler/pipelinerun/resources/pipelinerunstate.go 98.2% 97.9% -0.2

[TEP-0056]: Second PR of Pipelines-in-Pipelines feature implementation.

Extend existing methods in `pipelinerunstate.go` to check for child
`PipelirRuns` and add new test cases.

Issues tektoncd#8760, tektoncd#7166.

Signed-off-by: Stanislav Jakuschevskij <[email protected]>
@twoGiants twoGiants force-pushed the issue-8760-tep-0056-pinp-state branch from d4eaab4 to 68d6528 Compare July 12, 2025 12:50
@tekton-robot tekton-robot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Jul 12, 2025
@vdemeester vdemeester added this to the v1.3.0 (LTS) milestone Jul 16, 2025
@vdemeester vdemeester self-assigned this Jul 16, 2025
@vdemeester vdemeester modified the milestones: v1.3.0 (LTS), v1.4.0 Jul 28, 2025
@waveywaves
Copy link
Member

/kind feature

@waveywaves waveywaves modified the milestones: v1.4.0, v1.5.0 Aug 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. kind/feature Categorizes issue or PR as related to a new feature. release-note-none Denotes a PR that doesnt merit a release note. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
Status: Todo
Development

Successfully merging this pull request may close these issues.

4 participants