docs: clarify flag availability across controller binaries#9390
Open
lusqua wants to merge 1 commit intotektoncd:mainfrom
Open
docs: clarify flag availability across controller binaries#9390lusqua wants to merge 1 commit intotektoncd:mainfrom
lusqua wants to merge 1 commit intotektoncd:mainfrom
Conversation
|
|
Member
|
@lusqua please sign the CLA |
Member
|
@lusqua also, please follow the PR template |
Restructure the controller flags documentation to clearly show which flags and environment variables are available on each controller binary. Separate flags from knative/pkg (common to all controllers) from Tekton-specific flags, and add a per-controller availability table with corrections found during source code verification.
8e40c78 to
b3820c5
Compare
Author
|
/kind documentation |
8 tasks
vdemeester
approved these changes
Feb 16, 2026
Collaborator
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: vdemeester, waveywaves The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Restructure the
docs/tekton-controller-flags.mddocumentation to clearly communicate which flags and environment variables are available on each controller binary (controller,webhook,events,resolvers).What changed
knative/pkg(common to all controllers) are now clearly distinguished from Tekton-specific flagsresolversdoes not support--disable-ha(it usesMainWithConfig, notMainWithContext)controllerandresolversuseTHREADS_PER_CONTROLLERenv var (noK_prefix), whilewebhookandeventsuseK_THREADS_PER_CONTROLLER(withK_prefix) viasharedmainFixes #9292
Submitter Checklist
As the author of this PR, please check off the items in this checklist:
/kind <type>. Valid types are bug, cleanup, design, documentation, feature, flake, misc, question, tepRelease Notes