JEXL expression in subject.condition #4555 by orianar · Pull Request #4738 · telefonicaid/fiware-orion

orianar · 2025-12-16T03:49:52Z

@fgalan
So far, the JexlExpression field does not use macros. Should we add support for them?

fgalan · 2025-12-16T08:32:08Z

So far, the JexlExpression field does not use macros. Should we add support for them?

Do you mean

"jexlExpression": "${(A|isNaN) && (B|isNaN)}"

instead of

"jexlExpression": "(A|isNaN) && (B|isNaN)"

?

I think we don't need ${...} in this case, as this is not the same case than the ngsi notification payload (in which case, the string replaced by ${...} may be included in a larger string, eg: "this is my expresion: ${...}". In this case we only need to a value of truth (either true or false in a boolean way).

doc/manuals/admin/database_model.md

doc/manuals/orion-api.md

doc/manuals/admin/database_model.md

fgalan · 2025-12-17T08:38:38Z

src/lib/mongoBackend/MongoCommonUpdate.cpp

+        bool basic = false;
+    #endif
+
+    // Build JEXL evaluation contexts using entity attributes and their metadata


I'd suggest to do the JEXL evaluation after string filters (which is less expensive) and before than geo-evaluation (which is more expensive, as it hits de MongoDB).

Fixed in #1c20aeb

fgalan · 2025-12-17T08:41:29Z

src/lib/mongoBackend/MongoCommonUpdate.cpp

+      if (!result.boolValue)
+      {
+        continue;
+      }
+    }


In the case of the expression that evaluations to a number or string (e.g. 'a|logor 's|uppercase), isresult.boolValueset tofalse`?

The condition was changed and tests were added with these cases
https://github.com/telefonicaid/fiware-orion/pull/4738/files#diff-f3de384894601039a5d62bd71c655eade1dbf49e023cdacce6e843279808401bR2098

fgalan · 2025-12-17T12:01:51Z

doc/manuals/admin/database_model.md

@@ -302,6 +302,8 @@ Fields:
 -   **expression**: an expression used to evaluate if notifications has


CHANGES_NEXT_RELEASE entry regarding the changes in this PR should be included

Fixed in #bf39cba

fgalan · 2025-12-17T12:03:50Z

doc/manuals/orion-api.md

@@ -5033,6 +5033,8 @@ A `condition` contains the following subfields:
 | `expression` | ✓        | object| An expression composed of `q`, `mq`, `georel`, `geometry` and `coords` (see [List Entities](#list-entities-get-v2entities) operation above about this field). `expression` and sub elements (i.e. `q`) must have content, i.e. `{}` or `""` is not allowed. `georel`, `geometry` and `coords` have to be used together (i.e. "all or nothing"). Check the example using geoquery as expression [below](#create-subscription-post-v2subscriptions).|


We have a section "JEXL Support" https://github.com/telefonicaid/fiware-orion/blob/master/doc/manuals/orion-api.md#jexl-support but what it is actually describin in "JEXL Support in Custom Notifications"

I'd suggest to change this name, in the section title, in the TOC and in links (search for #jexl-support literal among directory files)

(Up to this PR, the diference was not meaninful, but now whe have JEXL support in a different place, i.e. subscription conditions, so I think is better changing the same)

Fixed in #1c20aeb

fgalan · 2025-12-17T12:06:01Z

...tionalTest/cases/4555_jexlexpression_in_subject_condition/sub_with_jexlexpression_patch.test

+# 01. Create httpCustom sub with subject.condition.jexlExpression
+# 02. Get sub, see sub with subject.condition.jexlExpression
+# 03. Update sub description
+# 04. Get sub, see subject.condition.jexlExpression
+# 05. Update sub subject.condition.jexlExpression
+# 06. see subject.condition.jexlExpression


I understand this .test is testing the basic CRUD of the new field. I'd suggest to add the following steps

# 07. Update subject.condition removing jexlExpression # 08. Get sub, see now jexlExpression in subject.condition # 09. Update subject.condition adding jexlExpression again # 10. Get sub, see subject.condition.jexlExpression

Fixed in#1c20aeb

fgalan · 2025-12-17T12:06:59Z

...nalTest/cases/4555_jexlexpression_in_subject_condition/jexl_basic_isnan_attrs_in_update.test

+# 01. Create custom sub with condition.JexlExpression (A|isNaN) && (B|isNaN)
+# 02. Create entity E1 with A=1 and B=2
+# 03. Update entity E1 with A=foo and B=bar
+# 04. Update entity E1 with A=2.1 and B=-3.8


Maybe better

Suggested change

# 04. Update entity E1 with A=2.1 and B=-3.8

# 04. Update entity E1 with A=zzzz and B=-3.8

To have a case in which the values of both operands in && are different

Fixed in#1c20aeb

fgalan · 2025-12-17T12:09:04Z

...exlexpression_in_subject_condition/jexl_expression_in_condition_sum_eq3_attrs_in_update.test

+# 04. Update entity E1 with A=2.1 and B=-3.8
+# 05. Dump accumulator and see ONE notification (only for step 02: A=1, B=2)
+#     (the updates in steps 03 and 04 must NOT trigger notifications)


I'd suggest to add an additional step:

Suggested change

# 04. Update entity E1 with A=2.1 and B=-3.8

# 05. Dump accumulator and see ONE notification (only for step 02: A=1, B=2)

# (the updates in steps 03 and 04 must NOT trigger notifications)

# 04. Update entity E1 with A=2.1 and B=-3.8

# 05. Update entity E1 with A=6.8 and B=-3.8

# 06. Dump accumulator and see TWO notification (for steps 02: A=1, B=2 and 05: A=6.8 and B=-3.8)

# (the updates in steps 03 and 04 must NOT trigger notifications)

fgalan · 2025-12-17T12:10:02Z

..._jexlexpression_in_subject_condition/jexl_expression_in_condition_isnan_attrs_in_update.test

@@ -0,0 +1,203 @@
+# Copyright 2025 Telefonica Investigacion y Desarrollo, S.A.U


I'd suggest to add a variant of this test in a new .test in which only one of the attributes comes in the notification (e.g. A) and the other is an existing one in the entity (e.g. B).

Fixed in #1c20aeb

fgalan · 2025-12-17T12:10:07Z

...exlexpression_in_subject_condition/jexl_expression_in_condition_sum_eq3_attrs_in_update.test

@@ -0,0 +1,203 @@
+# Copyright 2025 Telefonica Investigacion y Desarrollo, S.A.U


I'd suggest to add a variant of this test in a new .test in which only one of the attributes comes in the notification (e.g. A) and the other is an existing one in the entity (e.g. B).

Fixed in #1c20aeb

Co-authored-by: Fermín Galán Márquez <fgalan@users.noreply.github.com>

…thub.com:telefonicaid/fiware-orion into feature/4555_jexlexpression_in_subject_condition

doc/manuals/admin/database_model.md

doc/manuals/orion-api.md

Clarified notification triggering rules and expressions in the documentation.

doc/manuals/orion-api.md

orianar

LGTM

src/lib/mongoBackend/MongoCommonUpdate.cpp

doc/manuals/admin/statistics.md

doc/manuals/orion-api.md

Co-authored-by: Fermín Galán Márquez <fgalan@users.noreply.github.com>

doc/manuals/admin/statistics.md

...n_in_subject_condition/jexl_expression_in_condition_sum_eq3_mixed_update_existing_attrs.test

fgalan

LGTM (except for a small typo in one of the .test files)

…tion/jexl_expression_in_condition_sum_eq3_mixed_update_existing_attrs.test Co-authored-by: Fermín Galán Márquez <fgalan@users.noreply.github.com>

fgalan · 2026-01-07T18:15:11Z

@fisuda this PR does some modifications to .md English files. It would be great if you could sync the Japanese translation, please.

fisuda · 2026-01-08T04:02:17Z

I sent the PR #4739.
Thanks.

(JP) JEXL expression in subject.condition (#4738)

add 4555_jexlexpression_in_subject_condition

018862c

orianar force-pushed the feature/4555_jexlexpression_in_subject_condition branch from 4a1a886 to 018862c Compare December 16, 2025 03:54

fix

b7ea699

orianar added 2 commits December 16, 2025 12:03

fix tests without cache

4a79c64

add sub_with_jexlexpression_patch.test

67fe219

orianar changed the title ~~[WIP] JEXL expression in subject.condition #4555~~ JEXL expression in subject.condition #4555 Dec 17, 2025

orianar requested a review from fgalan December 17, 2025 04:22

fgalan reviewed Dec 17, 2025

View reviewed changes

doc/manuals/admin/database_model.md Outdated Show resolved Hide resolved

fgalan reviewed Dec 17, 2025

View reviewed changes

doc/manuals/orion-api.md Outdated Show resolved Hide resolved

fgalan reviewed Dec 17, 2025

View reviewed changes

doc/manuals/admin/database_model.md Outdated Show resolved Hide resolved

fgalan reviewed Dec 17, 2025

View reviewed changes

orianar and others added 7 commits December 17, 2025 17:15

Apply suggestions from code review

06158b5

Co-authored-by: Fermín Galán Márquez <fgalan@users.noreply.github.com>

add new tests

1c20aeb

Merge branch 'feature/4555_jexlexpression_in_subject_condition' of gi…

3323f0d

…thub.com:telefonicaid/fiware-orion into feature/4555_jexlexpression_in_subject_condition

fix step in jexl_expression_in_condition_sum_eq3_attrs_in_update.test

2fc796e

add tests with syntax error and unknown jexlExpression

a624edb

update CHANGES_NEXT_RELEASE

bf39cba

update CHANGES_NEXT_RELEASE

12be672

orianar requested a review from fgalan December 21, 2025 23:27