Secmotic fiQare PR#407
Closed
fiqare-secmotic wants to merge 8 commits intotelefonicaid:release/1.11.0from
Closed
Conversation
… should not be reassigned
Member
|
Thanks you very much for your contribution! Please have a look to the comments provided in telefonicaid/perseo-fe#416 (when applicable). |
Member
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request contains improvements made by the Secmotic team for iotagent-ul. These improvements are part of the fiQare project, which is based on ISO 25010 to improve software quality. More info: https://fiqare.eu/
<server_host>:7896/api-docsnpm installis neededThere are four rules:
Rule 1: Variables should not be shadowed
Rule 2: Unused function parameters should be removed
Rule 3: Function parameters, caught exceptions and foreach variables should not be reassigned
Rule 4: if.. else if constructs should end with else clauses
All test in Travis has been passed successfully and the coverage in Coveralls remains the same.