Vhost parameter added.#462
Vhost parameter added.#462sromerotech wants to merge 7 commits intotelefonicaid:masterfrom sromerotech:amqp-vhost
Conversation
docs/installationguide.md
Outdated
| | IOTA_MQTT_PROTOCOL | mqtt.protocol | | ||
| | IOTA_MQTT_HOST | mqtt.host | | ||
| | IOTA_MQTT_PORT | mqtt.port | | ||
| | IOTA_MQTT_VHOST | mqtt.vhost | |
There was a problem hiding this comment.
As far as I understand, the new vhost parameter is for AMQP configuration, not MQTT (looking to "twin" PR telefonicaid/iotagent-json#527 it only appears in the AMQP section of the configuration).
Is this a typo? Or maybe I'm missing something? :)
There was a problem hiding this comment.
Hello @fgalan and sorry for the delay. Yes, it was a typo. I've updated the PR. Thanks.
| @@ -0,0 +1,7941 @@ | |||
| { | |||
There was a problem hiding this comment.
This file should be removed from PR.
| @@ -1,5 +1,5 @@ | |||
| name: CI | |||
There was a problem hiding this comment.
Why this file has been changed in the PR?
In addition, looking to telefonicaid/iotagent-json#527 I don't see similar changes
|
There were some changes on that iotagent-node-lib library that make some tests to be "unaligned". It has been already fixed in master (by PR #476 ). Thus, could you please update this PR brach con master. After that I guess that all your changes in ci.yml in this PR are not needed and can be reverted. Remember also to remove packages-lock.json from the PR. Thanks! |
|
@sromerotech could you explain why this PR has been closed, please? Do you plan to re-create it? Thanks! |
3 participants
I've added the vhost parameter so you can customize it. I'll appreciate any feedback on this PR. Thanks in advance.