Fiqare perseo-core improvements by fiqare-emergya-dev · Pull Request #151 · telefonicaid/perseo-core

fiqare-emergya-dev · 2019-11-21T11:53:09Z

This pull request contains the improvements made by the Emergya team for perseo-core. These improvements are part of the fiQare project, which is based on ISO 25010 to improve software quality. More info: https://fiqare.eu/

There are 95 issues:
Rule | Severity | File
squid:S1075 | MINOR | fiware-perseo-core:src/main/java/com/telefonica/iot/perseo/Configuration.java
squid:S1313 | MINOR | fiware-perseo-core:src/main/java/com/telefonica/iot/perseo/Configuration.java
squid:S1075 | MINOR | fiware-perseo-core:src/main/java/com/telefonica/iot/perseo/Configuration.java
squid:EmptyStatementUsageCheck | MINOR | fiware-perseo-core:src/main/java/com/telefonica/iot/perseo/Constants.java
findsecbugs:XSS_SERVLET | MAJOR | fiware-perseo-core:src/main/java/com/telefonica/iot/perseo/EventsServlet.java
squid:S1854 | MAJOR | fiware-perseo-core:src/main/java/com/telefonica/iot/perseo/GenericListener.java
findsecbugs:XSS_SERVLET | MAJOR | fiware-perseo-core:src/main/java/com/telefonica/iot/perseo/LogLevelServlet.java
squid:S3457 | MAJOR | fiware-perseo-core:src/main/java/com/telefonica/iot/perseo/RulesManager.java
squid:S3776 | CRITICAL | fiware-perseo-core:src/main/java/com/telefonica/iot/perseo/RulesManager.java
findsecbugs:XSS_SERVLET | MAJOR | fiware-perseo-core:src/main/java/com/telefonica/iot/perseo/RulesServlet.java
findsecbugs:XSS_SERVLET | MAJOR | fiware-perseo-core:src/main/java/com/telefonica/iot/perseo/RulesServlet.java
findsecbugs:XSS_SERVLET | MAJOR | fiware-perseo-core:src/main/java/com/telefonica/iot/perseo/RulesServlet.java
findsecbugs:XSS_SERVLET | MAJOR | fiware-perseo-core:src/main/java/com/telefonica/iot/perseo/RulesServlet.java
squid:S3776 | CRITICAL | fiware-perseo-core:src/main/java/org/json/CDL.java
squid:S3776 | CRITICAL | fiware-perseo-core:src/main/java/org/json/CDL.java
squid:ForLoopCounterChangedCheck | MAJOR | fiware-perseo-core:src/main/java/org/json/Cookie.java
squid:S2589 | MAJOR | fiware-perseo-core:src/main/java/org/json/JSONArray.java
squid:S2225 | MAJOR | fiware-perseo-core:src/main/java/org/json/JSONArray.java
squid:S3776 | CRITICAL | fiware-perseo-core:src/main/java/org/json/JSONML.java
squid:S1854 | MAJOR | fiware-perseo-core:src/main/java/org/json/JSONML.java
squid:S3776 | CRITICAL | fiware-perseo-core:src/main/java/org/json/JSONML.java
squid:S3776 | CRITICAL | fiware-perseo-core:src/main/java/org/json/JSONML.java
squid:S2975 | BLOCKER | fiware-perseo-core:src/main/java/org/json/JSONObject.java
squid:S1182 | MINOR | fiware-perseo-core:src/main/java/org/json/JSONObject.java
squid:S1206 | MINOR | fiware-perseo-core:src/main/java/org/json/JSONObject.java
squid:S2589 | MAJOR | fiware-perseo-core:src/main/java/org/json/JSONObject.java
squid:S1168 | MAJOR | fiware-perseo-core:src/main/java/org/json/JSONObject.java
squid:S1168 | MAJOR | fiware-perseo-core:src/main/java/org/json/JSONObject.java
squid:S1168 | MAJOR | fiware-perseo-core:src/main/java/org/json/JSONObject.java
squid:S3776 | CRITICAL | fiware-perseo-core:src/main/java/org/json/JSONObject.java
squid:S3776 | CRITICAL | fiware-perseo-core:src/main/java/org/json/JSONObject.java
squid:S1181 | MAJOR | fiware-perseo-core:src/main/java/org/json/JSONObject.java
squid:S3776 | CRITICAL | fiware-perseo-core:src/main/java/org/json/JSONObject.java
squid:S2225 | MAJOR | fiware-perseo-core:src/main/java/org/json/JSONObject.java
squid:S2589 | MAJOR | fiware-perseo-core:src/main/java/org/json/JSONObject.java
squid:S2159 | MAJOR | fiware-perseo-core:src/main/java/org/json/JSONObject.java
squid:S2589 | MAJOR | fiware-perseo-core:src/main/java/org/json/JSONObject.java
squid:S2159 | MAJOR | fiware-perseo-core:src/main/java/org/json/JSONObject.java
squid:S3776 | CRITICAL | fiware-perseo-core:src/main/java/org/json/JSONObject.java
squid:SwitchLastCaseIsDefaultCheck | CRITICAL | fiware-perseo-core:src/main/java/org/json/JSONTokener.java
squid:ClassVariableVisibilityCheck | MINOR | fiware-perseo-core:src/main/java/org/json/Kim.java
squid:S3776 | CRITICAL | fiware-perseo-core:src/main/java/org/json/Kim.java
squid:ForLoopCounterChangedCheck | MAJOR | fiware-perseo-core:src/main/java/org/json/Kim.java
squid:ForLoopCounterChangedCheck | MAJOR | fiware-perseo-core:src/main/java/org/json/Kim.java
squid:HiddenFieldCheck | MAJOR | fiware-perseo-core:src/main/java/org/json/Kim.java
squid:S1659 | MINOR | fiware-perseo-core:src/main/java/org/json/XML.java
squid:S3776 | CRITICAL | fiware-perseo-core:src/main/java/org/json/XML.java
squid:S3776 | CRITICAL | fiware-perseo-core:src/main/java/org/json/XML.java
squid:S1854 | MAJOR | fiware-perseo-core:src/main/java/org/json/XML.java
squid:S2386 | MINOR | fiware-perseo-core:src/main/java/org/json/XMLTokener.java
squid:S3776 | CRITICAL | fiware-perseo-core:src/main/java/org/json/XMLTokener.java
squid:SwitchLastCaseIsDefaultCheck | CRITICAL | fiware-perseo-core:src/main/java/org/json/XMLTokener.java
squid:S3776 | CRITICAL | fiware-perseo-core:src/main/java/org/json/XMLTokener.java
squid:SwitchLastCaseIsDefaultCheck | CRITICAL | fiware-perseo-core:src/main/java/org/json/XMLTokener.java
squid:S3776 | CRITICAL | fiware-perseo-core:src/main/java/org/json/XMLTokener.java
squid:S00112 | MAJOR | fiware-perseo-core:src/test/java/com/telefonica/iot/perseo/EventsServletTest.java
squid:S106 | MAJOR | fiware-perseo-core:src/test/java/com/telefonica/iot/perseo/EventsServletTest.java
squid:S106 | MAJOR | fiware-perseo-core:src/test/java/com/telefonica/iot/perseo/GenericListenerTest.java
squid:S106 | MAJOR | fiware-perseo-core:src/test/java/com/telefonica/iot/perseo/GenericListenerTest.java
squid:S00112 | MAJOR | fiware-perseo-core:src/test/java/com/telefonica/iot/perseo/LogLevelServletTest.java
squid:S00112 | MAJOR | fiware-perseo-core:src/test/java/com/telefonica/iot/perseo/LogLevelServletTest.java
squid:S106 | MAJOR | fiware-perseo-core:src/test/java/com/telefonica/iot/perseo/LogLevelServletTest.java
squid:S00112 | MAJOR | fiware-perseo-core:src/test/java/com/telefonica/iot/perseo/LogLevelServletTest.java
squid:S106 | MAJOR | fiware-perseo-core:src/test/java/com/telefonica/iot/perseo/LogLevelServletTest.java
squid:S106 | MAJOR | fiware-perseo-core:src/test/java/com/telefonica/iot/perseo/RulesManagerTest.java
squid:S106 | MAJOR | fiware-perseo-core:src/test/java/com/telefonica/iot/perseo/RulesManagerTest.java
squid:S106 | MAJOR | fiware-perseo-core:src/test/java/com/telefonica/iot/perseo/RulesManagerTest.java
squid:S106 | MAJOR | fiware-perseo-core:src/test/java/com/telefonica/iot/perseo/RulesManagerTest.java
squid:S00112 | MAJOR | fiware-perseo-core:src/test/java/com/telefonica/iot/perseo/RulesServletTest.java
squid:S106 | MAJOR | fiware-perseo-core:src/test/java/com/telefonica/iot/perseo/RulesServletTest.java
squid:S106 | MAJOR | fiware-perseo-core:src/test/java/com/telefonica/iot/perseo/RulesServletTest.java
squid:S00112 | MAJOR | fiware-perseo-core:src/test/java/com/telefonica/iot/perseo/RulesServletTest.java
squid:S106 | MAJOR | fiware-perseo-core:src/test/java/com/telefonica/iot/perseo/RulesServletTest.java
squid:S00112 | MAJOR | fiware-perseo-core:src/test/java/com/telefonica/iot/perseo/RulesServletTest.java
squid:S106 | MAJOR | fiware-perseo-core:src/test/java/com/telefonica/iot/perseo/RulesServletTest.java
squid:S00112 | MAJOR | fiware-perseo-core:src/test/java/com/telefonica/iot/perseo/RulesServletTest.java
squid:S106 | MAJOR | fiware-perseo-core:src/test/java/com/telefonica/iot/perseo/RulesServletTest.java
squid:S00112 | MAJOR | fiware-perseo-core:src/test/java/com/telefonica/iot/perseo/RulesServletTest.java
squid:S106 | MAJOR | fiware-perseo-core:src/test/java/com/telefonica/iot/perseo/RulesServletTest.java
squid:ClassVariableVisibilityCheck | MINOR | fiware-perseo-core:src/test/java/com/telefonica/iot/perseo/test/EventBeanMock.java
squid:S2386 | MINOR | fiware-perseo-core:src/test/java/com/telefonica/iot/perseo/test/Help.java
squid:S2386 | MINOR | fiware-perseo-core:src/test/java/com/telefonica/iot/perseo/test/Help.java
squid:ClassVariableVisibilityCheck | MINOR | fiware-perseo-core:src/test/java/com/telefonica/iot/perseo/test/Help.java
squid:ClassVariableVisibilityCheck | MINOR | fiware-perseo-core:src/test/java/com/telefonica/iot/perseo/test/Help.java
squid:S00112 | MAJOR | fiware-perseo-core:src/test/java/com/telefonica/iot/perseo/test/Help.java
squid:S00112 | MAJOR | fiware-perseo-core:src/test/java/com/telefonica/iot/perseo/test/Help.java
squid:ClassVariableVisibilityCheck | MINOR | fiware-perseo-core:src/test/java/com/telefonica/iot/perseo/test/ServletContextMock.java
squid:S106 | MAJOR | fiware-perseo-core:src/test/java/com/telefonica/iot/perseo/TimeRulesStoreTest.java
squid:S106 | MAJOR | fiware-perseo-core:src/test/java/com/telefonica/iot/perseo/UtilsTest.java
squid:S106 | MAJOR | fiware-perseo-core:src/test/java/com/telefonica/iot/perseo/UtilsTest.java
squid:S106 | MAJOR | fiware-perseo-core:src/test/java/com/telefonica/iot/perseo/UtilsTest.java
squid:S106 | MAJOR | fiware-perseo-core:src/test/java/com/telefonica/iot/perseo/UtilsTest.java
squid:S106 | MAJOR | fiware-perseo-core:src/test/java/com/telefonica/iot/perseo/UtilsTest.java
squid:S106 | MAJOR | fiware-perseo-core:src/test/java/com/telefonica/iot/perseo/UtilsTest.java

All test in Travis has been passed successfully.

Merge by Jenkins

…re-src into emptystatements#284630

Merge by Jenkins

…Servlet.java src/main/java/com/telefonica/iot/perseo/LogLevelServlet.java src/main/java/com/telefonica/iot/perseo/RulesServlet.java

Merge by Jenkins

…uration.java src/main/resources/perseo-core.properties

Merge by Jenkins

…fiqare-emergya-dev/cdti-fiqare-perseo-core-src into fiqare-perseo-core-improvements

fgalan · 2020-01-23T09:21:11Z

Looking to the check style log:

However, I understand that should mention the telefonica_checkstyle.xml (https://github.com/telefonicaid/perseo-core/blob/master/telefonica_checkstyle.xml). It seems like you are not using the right rule set for perseo-core.

fiqare-emergya-dev · 2020-01-23T09:46:35Z

Looking to the check style log:

However, I understand that should mention the telefonica_checkstyle.xml (https://github.com/telefonicaid/perseo-core/blob/master/telefonica_checkstyle.xml). It seems like you are not using the right rule set for perseo-core.

The pom.xml file has this configuration:

Running the command 'mvn checkstyle:check' gives me the results mentioned above. Is the configuration wrong or am I running it wrong?

fgalan · 2020-01-23T19:20:59Z

Is the configuration wrong or am I running it wrong?

Indeed. Something in the configuration (pom.xml) could be wrong. Need to be investigated (probably out of the scope of this PR).

fgalan · 2020-01-24T14:36:21Z

Is the configuration wrong or am I running it wrong?

Indeed. Something in the configuration (pom.xml) could be wrong. Need to be investigated (probably out of the scope of this PR).

Moved to issue #156. Thus, we'll leave checstyle check out of the scope of this PR.

fgalan · 2020-01-24T14:51:11Z

perseo-main/src/main/java/com/telefonica/iot/perseo/Configuration.java

        String defaultMaxAge;
        String defaultURL;
-        String actionPath = "/actions/do";
+        String actionPath = ResourceBundle.getBundle("perseo-core").getString("action.path");


Not sure if this is correct...

I mean, looking above to:

private static final String PATH = ResourceBundle.getBundle("perseo-core").getString("properties.path");

I understand that ResourceBundle.getBundle("...").getString("...") is used to get the path of a filename. However, in case, /actions/do doesn't refer to a filename, but to an URL endpoint...

Looking to the content of perseo-main/src/main/resources/perseo-core.properties it seems I misunderstand this. Thus ResourceBundle.getBundle("...").getString("...") seems to be a way of getting properties from that file. Is my understanding correct?

The change is due to a rule that detects hardcoded url. If you consider that the path is not a url we reverse the change.

Please find my answer here: #151 (comment)

Fixed in 47ab836

Travis ci fixed in b4a4d73

fgalan · 2020-01-24T14:53:54Z

perseo-main/src/main/java/com/telefonica/iot/perseo/EventsServlet.java

-        PrintWriter out = response.getWriter();
-        try {
-            StringBuilder sb = new StringBuilder();
+        response.setContentType("application/json;charset=UTF-8");        


Wrong indent... again :)

You can self-discover this kind of problems along all the modified files if you have a carefull look to https://github.com/telefonicaid/perseo-core/pull/151/files. Please, do it.

Fixed in 47ab836

Travis ci fixed in b4a4d73

fgalan · 2020-01-24T14:54:11Z

perseo-main/src/main/java/com/telefonica/iot/perseo/EventsServlet.java

-            out.close();
+            logger.debug(String.format("event was sent: %s", eventMap));
+        } catch (Exception je) {
+        	try {        		


Wrong indent

Fixed in 47ab836

Travis ci fixed in b4a4d73

fgalan · 2020-01-24T14:55:01Z

perseo-main/src/main/java/com/telefonica/iot/perseo/LogLevelServlet.java

-            response.setContentType("application/json");
-            response.setStatus(HttpServletResponse.SC_OK);
-            response.getOutputStream().print("{\"level\":\""+ currentLevel +"\"}");
+             try {


Wrong indent

Fixed in 47ab836

Travis ci fixed in b4a4d73

Note really fixed... indent is not correct. An extra whitespace before try should be removed:

fgalan · 2020-01-24T15:03:15Z

perseo-main/src/main/resources/perseo-core.properties

+properties.path = /etc/perseo-core.properties
+action.path = /actions/do


Both parameters should have an explanatory comment above each one (as rule.max_age does). In addition, I understand the new parameters should be included in documentation/config.md.

In addition, it seems that action.url includes a part that is the value off action.path. This is a bit weird, isn't it?

The change is due to a rule that detects the hardcoded urls and for that reason it was decided to take them out to a configuration file. If the path is considered not to be a url, the change is reversed.

It is an URL. However, looking how it is used in Configuration.java

perseo-core/perseo-main/src/main/java/com/telefonica/iot/perseo/Configuration.java

Lines 96 to 99 in cff907d

if (Utils.isValidURL(perseoFeURLEnv)) {

// Add actions/do path if perseoFeURLEnv not contains it yet

actionRule = perseoFeURLEnv.contains(actionPath) ? perseoFeURLEnv : perseoFeURLEnv + actionPath;

} else {

actionPath is just a default to complete the URL in the case it the action URL that comes from action.url (in the configuration file) or PERSEO_FE_URL (as env var). Thus, yes, probably better to revert this particular change.

Fixed in 47ab836

Travis ci fixed in b4a4d73

fgalan · 2020-01-24T15:03:43Z

perseo-main/src/test/java/com/telefonica/iot/perseo/EventsServletTest.java

 */
 public class EventsServletTest {
-
+	private static final Logger logger = LoggerFactory.getLogger(EventsServletTest.class);


Wrong indent. An a blank like should be added as separator.

Fixed in 47ab836

Travis ci fixed in b4a4d73

fgalan · 2020-01-24T15:03:54Z

perseo-main/src/test/java/com/telefonica/iot/perseo/GenericListenerTest.java

 */
 public class GenericListenerTest {
-
+	private static final Logger logger = LoggerFactory.getLogger(GenericListenerTest.class);


Fixed in 47ab836

Travis ci fixed in b4a4d73

fgalan · 2020-01-24T15:04:33Z

perseo-main/src/test/java/com/telefonica/iot/perseo/LogLevelServletTest.java

 public class LogLevelServletTest {
-
+
+	private static final Logger logger = LoggerFactory.getLogger(LogLevelServletTest.class);


Same here (and last time I mention :D, please do a general review in all files)-

Fixed in 47ab836

Travis ci fixed in b4a4d73

fgalan · 2020-01-24T15:04:57Z

perseo-main/src/test/java/com/telefonica/iot/perseo/RulesServletTest.java

+            jr.put("text", Help.ExampleRules()[0]);
            Help.Res r = Help.sendPost(url, jr.toString(2));
-            assertEquals(200, r.code);
+            assertEquals(200,r.getCode());


Suggested change

assertEquals(200,r.getCode());

assertEquals(200, r.getCode());

Fixed in 47ab836

Travis ci fixed in b4a4d73

fgalan · 2020-01-24T15:06:24Z

perseo-main/src/test/java/com/telefonica/iot/perseo/UtilsTest.java

 */
 public class UtilsTest {
-
+	private static final Logger logger = LoggerFactory.getLogger(UtilsTest.class);


Should be LOGGER? As in perseo-main/src/test/java/com/telefonica/iot/perseo/TimeRulesStoreTest.java

(The same in general for all the other similar files)

Fixed in 47ab836

Travis ci fixed in b4a4d73

fgalan · 2020-01-24T15:07:10Z

perseo-main/src/test/java/com/telefonica/iot/perseo/test/Help.java

+    public static String[] ExampleRules() {
+    	return new String[]{
+    			 "select id, price? as Price from iotEvent.win:length(100) group by id",
+    	            "@Audit select *,\"blood_1_action\" as iotcepaction,"
+    	            + "ev.BloodPressure? as Pression, ev.id? as Meter from pattern "
+    	            + "[every ev=iotEvent(cast(cast(BloodPressure?,String),float)>1.5"
+    	            + " and type=\"BloodMeter\")]"};
+
+    }
+    public static String[] ExampleNotices() {
+    	return new String[]{
+                "{\n"
+                        + "\"BloodPressure\": 2,\n"
+                        + "\"id\":\"guay!\",\n"
+                        + "\"otro\":\"mas\",\n"
+                        + "\"numero\":4,\n"
+                        + "\"sub\": {\n"
+                        + "	\"subnumero\":18,\n"
+                        + "	\"subcadena\":\"SUB2\",\n"
+                        + "	\"subflotante\": 12.3,\n"
+                        + "	\"sub2\": { \"valor\": 3}\n"
+                        + "	}\n"
+                        + "}"};


Indent seems a bit crazy in this part...

Fixed in 47ab836

Travis ci fixed in b4a4d73

fgalan · 2020-01-24T15:07:46Z

perseo-utils/src/main/java/com/telefonica/iot/perseo/utils/DateTimeUtils.java

- * perseo-core is free software: you can redistribute it and/or modify it under the terms of the GNU
- * General Public License version 2 as published by the Free Software Foundation.
+ * perseo-core is free software: you can redistribute it and/or
+ * modify it under the terms of the GNU
+ * General Public License version 2 as published by the Free Software
+ * Foundation.
 *
- * perseo-core is distributed in the hope that it will be useful, but WITHOUT ANY WARRANTY; without even the
- * implied warranty of MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU General Public License
+ * perseo-core is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the
+ * implied warranty of MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.
+ * See the GNU General Public License
 * for more details.
 *
- * You should have received a copy of the GNU General Public License along with perseo-core. If not, see
+ * You should have received a copy of the GNU General Public License
+ * along with perseo-core. If not, see
 * http://www.gnu.org/licenses/.
 *
- * For those usages not covered by the GNU General Public License please contact with
+ * For those usages not covered by the GNU General Public License
+ * please contact with


Please don't change existing licence headers.

Fixed in 47ab836

Travis ci fixed in b4a4d73

fgalan · 2020-01-30T08:20:56Z

perseo-main/src/main/java/com/telefonica/iot/perseo/Configuration.java

 import java.io.IOException;
 import java.io.InputStream;
 import java.util.Properties;
+import java.util.ResourceBundle;


It seem that after last changes ResourceBunle is no longer used in this file. Thus, this import line should be removed.

Fixed in b6d7148

fgalan · 2020-01-30T08:29:36Z

perseo-main/src/main/resources/perseo-core.properties

@@ -25,4 +25,5 @@ action.url = http://127.0.0.1:9090/actions/do



After the last changes, I understand the changes in this file should be reverted, as properties.path and action.path are no longer used in the code.

Fixed in b6d7148

fgalan · 2020-01-30T08:31:56Z

perseo-main/src/test/java/com/telefonica/iot/perseo/test/Help.java

+                "{\n"
+                        + "\"BloodPressure\": 2,\n"
+                        + "\"id\":\"guay!\",\n"
+                        + "\"otro\":\"mas\",\n"
+                        + "\"numero\":4,\n"
+                        + "\"sub\": {\n"
+                        + " \"subnumero\":18,\n"
+                        + " \"subcadena\":\"SUB2\",\n"
+                        + " \"subflotante\": 12.3,\n"
+                        + " \"sub2\": { \"valor\": 3}\n"
+                        + " }\n"
+                        + "}"};


This indent should look like more like the origina one, e.g. see the aligment of "{\n" and + "}"};

Fixed in b6d7148

fgalan · 2020-01-30T08:43:15Z

.gitignore

@@ -17,4 +17,3 @@ hs_err_pid*
 target


It seems the PR is close to the end :)

Thus, please add an entry in the CHANGES_NEXT_RELEASE about the changes. The following is the suggested one:

- Hardening: software quality improvement based on ISO25010 recommendations

Fixed in b6d7148

fiqare-emergya-dev and others added 30 commits February 5, 2019 17:51

Add JaCoCo plugin

6d25f8d

Merge pull request #2 from Emergya/configuration-branch

ab122f2

Merge by Jenkins

#284620

f651423

Delete innecesary comments

a1c8d23

Merge pull request #3 from Emergya/configuration-branch

fa2197f

Merge by Jenkins

Merge pull request #4 from Emergya/284620

99263f2

Merge by Jenkins

#284620

5c7825b

Merge pull request #5 from Emergya/284620

cbfad26

Merge by Jenkins

Fixed Dockerfile

18d5393

Fixed Dockerfile

c4c89f3

284621

04e9cbb

284621

e90be87

Fixed Dockerfile

9dc7421

Merge pull request #7 from Emergya/Dockerfile-fixed

032f6b8

Merge by Jenkins

Merge pull request Emergya#9 from Emergya/284621

c361bf3

Merge by Jenkins

Add 'default' clauses

8ff7828

Added comment in default clauses

8050a3d

Merge pull request Emergya#10 from Emergya/defaultclauses#284631

86f9044

Merge by Jenkins

Fill in the empty statements

6fa32ad

Merge branch 'ci' of https://github.com/Emergya/cdti-fiqare-perseo-co…

7de5632

…re-src into emptystatements#284630

Merge pull request Emergya#11 from Emergya/emptystatements#284630

40094b8

Merge by Jenkins

Refactor code

3e386ac

Merge pull request Emergya#12 from Emergya/emptystatements#284630

2ad08b7

Merge by Jenkins

Separate variables

bc7419d

Merge pull request Emergya#13 from Emergya/multiplevariables#284636

30ef6b4

Merge by Jenkins

Fixed issue #284627 in src/main/java/com/telefonica/iot/perseo/Events…

4ab8d47

…Servlet.java src/main/java/com/telefonica/iot/perseo/LogLevelServlet.java src/main/java/com/telefonica/iot/perseo/RulesServlet.java

Fixed issue #284627 in pom.xml

149d591

Merge pull request Emergya#14 from Emergya/284627

cd90313

Merge by Jenkins

Fixed issue #284639 in src/main/java/com/telefonica/iot/perseo/Config…

5e43ec8

…uration.java src/main/resources/perseo-core.properties

Merge pull request Emergya#15 from Emergya/284639

65ac79d

Merge by Jenkins

fiqare-emergya-dev added 2 commits January 23, 2020 10:11

pr fixes

61b8a4c

Merge branch 'fiqare-perseo-core-improvements' of https://github.com/…

cff907d

…fiqare-emergya-dev/cdti-fiqare-perseo-core-src into fiqare-perseo-core-improvements

fgalan mentioned this pull request Jan 24, 2020

Checkstyle seems to be broken #156

Open

fgalan reviewed Jan 24, 2020

View reviewed changes

fiqare-emergya-dev added 2 commits January 28, 2020 10:35

pr fixes

47ab836

pr fixed

b4a4d73

fgalan reviewed Jan 30, 2020

View reviewed changes

fiqare-emergya-dev added 2 commits January 31, 2020 14:30

pr fixed

b6d7148

travis fixed

728e600

fgalan changed the base branch from master to hardening/fiqare-perseo-core-improvements-prelanding February 4, 2020 07:53

fgalan merged commit 4dc0b14 into telefonicaid:hardening/fiqare-perseo-core-improvements-prelanding Feb 4, 2020

fgalan mentioned this pull request Feb 4, 2020

FIX software quality improvement based on ISO25010 recommendations #157

Merged

		properties.path = /etc/perseo-core.properties
		action.path = /actions/do

	if (Utils.isValidURL(perseoFeURLEnv)) {
	// Add actions/do path if perseoFeURLEnv not contains it yet
	actionRule = perseoFeURLEnv.contains(actionPath) ? perseoFeURLEnv : perseoFeURLEnv + actionPath;
	} else {

		public class LogLevelServletTest {


		private static final Logger logger = LoggerFactory.getLogger(LogLevelServletTest.class);

	assertEquals(200,r.getCode());
	assertEquals(200, r.getCode());

		@@ -25,4 +25,5 @@ action.url = http://127.0.0.1:9090/actions/do

Conversation

fiqare-emergya-dev commented Nov 21, 2019

Uh oh!

fgalan commented Jan 23, 2020

Uh oh!

fiqare-emergya-dev commented Jan 23, 2020

Uh oh!

fgalan commented Jan 23, 2020

Uh oh!

fgalan commented Jan 24, 2020

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

fgalan Jan 24, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

fgalan Jan 24, 2020 •

edited

Loading

fgalan Jan 24, 2020 •

edited

Loading