Mateusz malecki recruitment task #46
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 9 commits
November 27, 2024 16:21
…, adds api endpoint for getting the exchange rates
…te before 12AM; extends input description
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Na zadanie poświęciłem łącznie około 4h.
Starałem się zaprezentować znajomość mechanizmów z Reacta, Symfony czy dobrych praktyk programowania. Dla rzeczywistej aplikacji poświęciłbym więcej czasu na testy, rozwinąłbym error handling i wprowadził dokumentację endpointów przy wykorzystaniu OpenAPI. Można również wprowadzić bardziej zaawansowaną strukturę utrzymującą separacje zależności, ale zrezygnowałem z tego, aby utrzymać prostotę.
Walidacja dat mogłaby też być poprawiona, gdyż API NBP nie zwraca wyników dla soboty i niedzieli.