fix: parent node to be of type fragment for slots #914
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR, helps in converting the parentNode to of type
Fragmentwhen the prop is of typeelement. We do this only if the prop'sdefaultValueelement is of typefragment. This is to make sure, we are not converting the element type fornamed-slot. We do have a prop of type element which we are using for named-slot.Here is a reference
https://github.com/teleporthq/teleport-code-generators/blob/development/examples/uidl-samples/project.json#L6726
If we don't follow the convention, we will be changing the structure of the layout. So, when you want this behaviour to kick-in. Always pass the root node of defaultValue of the prop to start with
fragment.