Skip to content

Conversation

@Tsvetomir-Hr
Copy link
Contributor

@Tsvetomir-Hr Tsvetomir-Hr requested a review from a team October 15, 2024 14:01
@Tsvetomir-Hr Tsvetomir-Hr self-assigned this Oct 15, 2024
@Tsvetomir-Hr Tsvetomir-Hr requested a review from a team as a code owner October 15, 2024 14:01
@Tsvetomir-Hr Tsvetomir-Hr requested a review from ikoevska October 17, 2024 07:34
@ntacheva
Copy link
Contributor

I suggest syncing the casing here too https://github.com/telerik/blazor-docs/pull/2432/files#diff-4f8cf1be9ba87c8b575f353708fef2e90169e66c4dfb96f9bbbd6d8583de3dd9R25 ("month" -> "Month").
For some reason, I cannot add a suggestion that you can directly commit :/

Copy link
Contributor

@ntacheva ntacheva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Listed in the above comments.

@ntacheva
Copy link
Contributor

ntacheva commented Oct 18, 2024

I would also suggest moving the "Agenda" view before the "Timeline" in the documentation structure. Currently, we only have "Timeline" but in future we will add more similar views - "TimelineWeek", "TimelineMonth" etc.
Reordering the articles now will allow us easily add new views below afterwards without further reordering (reference).

@Tsvetomir-Hr
Copy link
Contributor Author

Tsvetomir-Hr commented Oct 18, 2024

I would also suggest moving the "Agenda" view before the "Timeline"

I confirm that it is a valid argument that in the future if we add more views will be easier to order them, but I synced this with other team members and their opinion was to be last in the docs structure, like in the UI:
image.
With that in mind, I've ordered them the same.

cc: @ntacheva

@ntacheva
Copy link
Contributor

I would also suggest moving the "Agenda" view before the "Timeline"

I confirm that it is a valid argument that in the future if we add more views will be easier to order them, but I synced this with other team members and their opinion was to be last in the docs structure, like in the UI: image. With that in mind, I've ordered them the same.

cc: @ntacheva

I am not against keeping the current order, especially if it matches the views order in the demo. We can keep it as is and reorder the views as needed when we add the rest of the timeline views.

@Tsvetomir-Hr Tsvetomir-Hr requested a review from ntacheva October 21, 2024 10:50
@Tsvetomir-Hr Tsvetomir-Hr merged commit 0a97ff9 into master Oct 21, 2024
1 check passed
@github-actions github-actions bot deleted the docs-agenda-view branch October 21, 2024 13:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants