Skip to content

Conversation

@kendo-bot
Copy link
Collaborator

@kendo-bot kendo-bot commented Nov 13, 2024

@kendo-bot kendo-bot requested a review from a team as a code owner November 13, 2024 13:05
@Tsvetomir-Hr Tsvetomir-Hr requested a review from a team November 13, 2024 13:07
@Tsvetomir-Hr Tsvetomir-Hr self-assigned this Nov 13, 2024
Copy link
Contributor

@dimodi dimodi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ideally, the KB should show how to calculate the dynamic margins on the fly, instead of hard-coding them. The targets may be rotated at a random angle every time. However, this is not required, as it's outside our scope. That's why...

Another suggestion is to move the margin approach to the second place and make the inner target look more prominent in the first position.

@dimodi
Copy link
Contributor

dimodi commented Nov 15, 2024

Add a merge-to-production label.

@Tsvetomir-Hr Tsvetomir-Hr added the merge-to-production Use this label to get a comment to choose whether to merge the PR to production label Nov 18, 2024
@github-actions
Copy link
Contributor

Hello @Tsvetomir-Hr,

Check the below option if you would like to automatically generate PR to production. The automation uses the branch for the cherry-pick, and then will delete the branch. Please, do not delete it manually.

  • create PR to production

@Tsvetomir-Hr Tsvetomir-Hr merged commit 3dbaa99 into master Nov 18, 2024
2 checks passed
@github-actions
Copy link
Contributor

Here you are the link to your PR to production: 2537

@github-actions github-actions bot deleted the new-kb-tooltip-position-rotated-div-8b8874329f9c4377b99080961d54b93f branch November 18, 2024 14:10
VelinovAngel pushed a commit that referenced this pull request Nov 26, 2024
* Added new kb article tooltip-position-rotated-div

* chore(kb): update slug and examples

* chore: apply recommendations

---------

Co-authored-by: KB Bot <[email protected]>
Co-authored-by: Tsvetomir Hristov <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

merge-to-production Use this label to get a comment to choose whether to merge the PR to production

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants