Skip to content

kb(common): Add KB for InPlaceEditor component #2532

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 12 commits into from
Nov 21, 2024
Merged

kb(common): Add KB for InPlaceEditor component #2532

merged 12 commits into from
Nov 21, 2024

Conversation

@dimodi
Copy link
Contributor

@dimodi dimodi commented Nov 14, 2024

No description provided.

@dimodi dimodi added the merge-to-production Use this label to get a comment to choose whether to merge the PR to production label Nov 14, 2024
@dimodi dimodi requested a review from a team as a code owner November 14, 2024 18:15
@github-actions
Copy link
Contributor

github-actions bot commented Nov 14, 2024

Hello @dimodi,

Check the below option if you would like to automatically generate PR to production. The automation uses the branch for the cherry-pick, and then will delete the branch. Please, do not delete it manually.

  • create PR to production

dimodi
dimodi commented Nov 14, 2024
View reviewed changes
dimodi
dimodi commented Nov 14, 2024
View reviewed changes
dimodi
dimodi commented Nov 14, 2024
View reviewed changes
dimodi
dimodi commented Nov 14, 2024
View reviewed changes
ntacheva
ntacheva reviewed Nov 20, 2024
View reviewed changes
ntacheva
ntacheva reviewed Nov 20, 2024
View reviewed changes
@ntacheva
Copy link
Contributor

ntacheva commented Nov 20, 2024

It looks to me that the Show Icon = Hover does not work. As I understand, this configuration is expected to affect the edit icon here:
image

The Never option hides the icon but Hover does not change anything.

@ntacheva
Copy link
Contributor

ntacheva commented Nov 20, 2024

A couple more points:

  • I am concerned about the naming. TelerikInPlaceEditor may indicate that it is an actual supported component considering teh naming for ur components and this is not the case.
  • Parts of the description are not logically related to the included InPlaceEditor. For example:
image I find it a bit odd as I don't see the relation between the icons and the time value.

@dimodi
Copy link
Contributor Author

dimodi commented Nov 21, 2024

It looks to me that the Show Icon = Hover does not work. As I understand, this configuration is expected to affect the edit icon here: image

The Never option hides the icon but Hover does not change anything.

CSS isolation stylesheet cache. I added a note about this in the KB.

@dimodi dimodi requested a review from ntacheva November 21, 2024 10:16
@dimodi dimodi merged commit c85882f into master Nov 21, 2024
1 check passed
@github-actions
Copy link
Contributor

github-actions bot commented Nov 21, 2024

Here you are the link to your PR to production: 2553

@github-actions github-actions bot mentioned this pull request Nov 21, 2024
Merged
@github-actions github-actions bot deleted the kb-inplaceeditor branch November 21, 2024 11:56
VelinovAngel pushed a commit that referenced this pull request Nov 26, 2024
@dimodi @ntacheva @VelinovAngel
kb(common): Add KB for InPlaceEditor component (#2532)
7429daf 
* kb(common): Add KB for InPlaceEditor component

* Update knowledge-base/in-place-editor.md

* Update knowledge-base/in-place-editor.md

* Update knowledge-base/in-place-editor.md

* Update knowledge-base/in-place-editor.md

* Class and Title parameters

* Core formatting

* Add Cancel feature

* Add Save and Cancel buttons

* Update knowledge-base/in-place-editor.md

Co-authored-by: Nadezhda Tacheva <[email protected]>

* apply suggestions

* Add note about CSS isolation

---------

Co-authored-by: Nadezhda Tacheva <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ntacheva ntacheva ntacheva approved these changes

Assignees

@dimodi dimodi

Labels

merge-to-production Use this label to get a comment to choose whether to merge the PR to production

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@dimodi @ntacheva