Skip to content

Conversation

@ntacheva
Copy link
Contributor

No description provided.

@ntacheva ntacheva added the merge-to-production Use this label to get a comment to choose whether to merge the PR to production label Nov 28, 2024
@ntacheva ntacheva self-assigned this Nov 28, 2024
@ntacheva ntacheva requested review from a team as code owners November 28, 2024 14:35
@github-actions
Copy link
Contributor

Hello @ntacheva,

Check the below option if you would like to automatically generate PR to production. The automation uses the branch for the cherry-pick, and then will delete the branch. Please, do not delete it manually.

  • create PR to production

@ntacheva ntacheva merged commit b94dd82 into master Nov 28, 2024
2 checks passed
@github-actions
Copy link
Contributor

Automatic cherry-pick & PR to production failed. Ping @telerik/blazor-admins for manual cherry-pick and push to production.

@github-actions github-actions bot deleted the update-package-sorce-mapping branch November 28, 2024 14:50
Copy link
Contributor

@ikoevska ikoevska left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed.

The `Telerik.UI.for.Blazor` NuGet package and most of its dependencies reside on `nuget.telerik.com`. On the other hand, the [Telerik icon packages]({%slug common-features-icons%}) reside on `nuget.org`. The correct [package source mapping](https://learn.microsoft.com/en-us/nuget/consume-packages/package-source-mapping) configuration should be similar to:
> Make sure that the `key` values in the `packageSourceMapping` section match the `key` values in the `packageSources` section, otherwise you will get a "Package not found" error.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Our style guide recommends code formatting for error messages.

Suggested change
> Make sure that the `key` values in the `packageSourceMapping` section match the `key` values in the `packageSources` section, otherwise you will get a "Package not found" error.
> Make sure that the `key` values in the `packageSourceMapping` section match the `key` values in the `packageSources` section, otherwise you will get a `Package not found` error.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

merge-to-production Use this label to get a comment to choose whether to merge the PR to production

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants