Skip to content

Conversation

@kendo-bot
Copy link
Collaborator

No description provided.

@kendo-bot kendo-bot requested a review from a team as a code owner November 28, 2024 15:47
@xristianstefanov xristianstefanov self-assigned this Nov 28, 2024
@xristianstefanov xristianstefanov added the merge-to-production Use this label to get a comment to choose whether to merge the PR to production label Nov 28, 2024
@github-actions
Copy link
Contributor

Hello @xristianstefanov,

Check the below option if you would like to automatically generate PR to production. The automation uses the branch for the cherry-pick, and then will delete the branch. Please, do not delete it manually.

  • create PR to production


2. In the `OnChange` event handler, update the map's `Center` property to the coordinates of the selected marker.

````RAZOR
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use

  • caption
  • capital letters for component properties
  • nameof() for field names
  • two-way binding for Map Zoom

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All comments are addressed except for the two-way binding for Zoom as the Map does not support it.

@xristianstefanov xristianstefanov merged commit 2f13055 into master Nov 29, 2024
1 check passed
@github-actions
Copy link
Contributor

Here you are the link to your PR to production: 2590

@github-actions github-actions bot deleted the new-kb-map-center-on-selected-marker-666960cb78bc4d8f874668b863c9f59d branch November 29, 2024 14:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

merge-to-production Use this label to get a comment to choose whether to merge the PR to production

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants