Skip to content

Conversation

@dimodi
Copy link
Contributor

@dimodi dimodi commented Jan 24, 2025

No description provided.

@dimodi dimodi added the merge-to-production Use this label to get a comment to choose whether to merge the PR to production label Jan 24, 2025
@dimodi dimodi requested review from a team as code owners January 24, 2025 15:04
@github-actions
Copy link
Contributor

Hello @dimodi,

Check the below option if you would like to automatically generate PR to production. The automation uses the branch for the cherry-pick, and then will delete the branch. Please, do not delete it manually.

  • create PR to production

Copy link
Contributor

@ikoevska ikoevska left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The syntax seems to be the correct one (looking only at the source) and everything builds both for dev and production without any issue (broken slugs are a bloker, so having a successful build is a good sign).

However, even though I was able to build both the docs and the API ref locally, I haven't been able to run the site successfully. Hence, I wasn't able to verify that everything works. Keep in mind that you might need to do a sanity check when deployed on staging.

@dimodi dimodi merged commit 85a7636 into master Jan 27, 2025
1 check passed
@github-actions
Copy link
Contributor

Automatic cherry-pick & PR to production failed. Ping @telerik/blazor-admins for manual cherry-pick and push to production.

@github-actions github-actions bot deleted the api-slugs branch January 27, 2025 10:50
dimodi added a commit that referenced this pull request Jan 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

merge-to-production Use this label to get a comment to choose whether to merge the PR to production

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants