Skip to content

chore(grid): refactor export notes #2835

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 28 commits into from
Mar 28, 2025
Merged

chore(grid): refactor export notes #2835

merged 28 commits into from
Mar 28, 2025

Conversation

@ntacheva
Copy link
Contributor

@ntacheva ntacheva commented Mar 13, 2025

@ntacheva ntacheva added the merge-to-production Use this label to get a comment to choose whether to merge the PR to production label Mar 13, 2025
@ntacheva ntacheva self-assigned this Mar 13, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Mar 13, 2025

Hello @ntacheva,

Check the below option if you would like to automatically generate PR to production. The automation uses the branch for the cherry-pick, and then will delete the branch. Please, do not delete it manually.

  • create PR to production

@ntacheva ntacheva marked this pull request as ready for review March 20, 2025 17:07
@ntacheva ntacheva requested review from a team as code owners March 20, 2025 17:07
ikoevska
ikoevska approved these changes Mar 24, 2025
View reviewed changes
Copy link
Contributor

@ikoevska ikoevska left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note that there are some readability issues throughout, as well as missing or broken links.

ntacheva and others added 12 commits March 25, 2025 12:16
@ntacheva @ikoevska
Update components/grid/export/excel.md
d2a884d 
Co-authored-by: Iva Stefanova Koevska-Atanasova <[email protected]>
@ntacheva @ikoevska
Update knowledge-base/grid-load-cyrillic-fonts-in-pdf-export.md
946a8bd 
Co-authored-by: Iva Stefanova Koevska-Atanasova <[email protected]>
@ntacheva @ikoevska
Update knowledge-base/grid-show-loader-while-exporting.md
74df580 
Co-authored-by: Iva Stefanova Koevska-Atanasova <[email protected]>
@ntacheva @ikoevska
Update knowledge-base/grid-show-loader-while-exporting.md
b1f0c08 
Co-authored-by: Iva Stefanova Koevska-Atanasova <[email protected]>
@ntacheva @ikoevska
Update components/grid/export/excel.md
f614827 
Co-authored-by: Iva Stefanova Koevska-Atanasova <[email protected]>
@ntacheva @ikoevska
Update components/grid/export/overview.md
0182f52 
Co-authored-by: Iva Stefanova Koevska-Atanasova <[email protected]>
@ntacheva @ikoevska
Update components/grid/export/overview.md
615236d 
Co-authored-by: Iva Stefanova Koevska-Atanasova <[email protected]>
@ntacheva @ikoevska
Update components/grid/export/overview.md
7185cad 
Co-authored-by: Iva Stefanova Koevska-Atanasova <[email protected]>
@ntacheva @ikoevska
Update knowledge-base/grid-load-cyrillic-fonts-in-pdf-export.md
624c530 
Co-authored-by: Iva Stefanova Koevska-Atanasova <[email protected]>
@ntacheva @ikoevska
Update components/grid/export/pdf.md
88acdfc 
Co-authored-by: Iva Stefanova Koevska-Atanasova <[email protected]>
@ntacheva @ikoevska
Update knowledge-base/grid-load-cyrillic-fonts-in-pdf-export.md
d821ee1 
Co-authored-by: Iva Stefanova Koevska-Atanasova <[email protected]>
@ntacheva
chore(grid): address feedback
4bb1009
dimodi
dimodi reviewed Mar 25, 2025
View reviewed changes
dimodi
dimodi reviewed Mar 25, 2025
View reviewed changes
dimodi
dimodi reviewed Mar 25, 2025
View reviewed changes
dimodi
dimodi reviewed Mar 25, 2025
View reviewed changes
dimodi
dimodi reviewed Mar 25, 2025
View reviewed changes
dimodi
dimodi reviewed Mar 25, 2025
View reviewed changes
dimodi
dimodi reviewed Mar 25, 2025
View reviewed changes
dimodi
dimodi reviewed Mar 25, 2025
View reviewed changes
dimodi
dimodi reviewed Mar 25, 2025
View reviewed changes
dimodi
dimodi reviewed Mar 25, 2025
View reviewed changes
dimodi
dimodi reviewed Mar 25, 2025
View reviewed changes
dimodi
dimodi reviewed Mar 25, 2025
View reviewed changes
dimodi
dimodi reviewed Mar 25, 2025
View reviewed changes
dimodi
dimodi reviewed Mar 25, 2025
View reviewed changes
dimodi
dimodi reviewed Mar 25, 2025
View reviewed changes
ntacheva and others added 10 commits March 25, 2025 18:29
@ntacheva @dimodi
Update components/grid/export/overview.md
624e886 
Co-authored-by: Dimo Dimov <[email protected]>
@ntacheva @dimodi
Update components/grid/export/overview.md
d646ccf 
Co-authored-by: Dimo Dimov <[email protected]>
@ntacheva @dimodi
Update components/grid/export/overview.md
3693bcd 
Co-authored-by: Dimo Dimov <[email protected]>
@ntacheva @dimodi
Update components/grid/export/overview.md
cca2f0a 
Co-authored-by: Dimo Dimov <[email protected]>
@ntacheva @dimodi
Update components/grid/export/overview.md
f13b5bc 
Co-authored-by: Dimo Dimov <[email protected]>
@ntacheva @dimodi
Update components/grid/export/pdf.md
9e19c5f 
Co-authored-by: Dimo Dimov <[email protected]>
@ntacheva @dimodi
Update components/grid/export/overview.md
511ea83 
Co-authored-by: Dimo Dimov <[email protected]>
@ntacheva
chore(grid): address feedback
4adc76f
@ntacheva
chore(grid): final updates
2c3ae2a
@ntacheva
chore(grid): update note
998960d
@ntacheva ntacheva merged commit c95456b into master Mar 28, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Mar 28, 2025

Here you are the link to your PR to production: 2882

@github-actions github-actions bot mentioned this pull request Mar 28, 2025
Merged
@github-actions github-actions bot deleted the refactor-export-notes branch March 28, 2025 16:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dimodi dimodi dimodi left review comments

@ikoevska ikoevska ikoevska approved these changes

Assignees

@ntacheva ntacheva

Labels

merge-to-production Use this label to get a comment to choose whether to merge the PR to production

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@ntacheva @dimodi @ikoevska