docs(ChipList): Enhance Events example #2963
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dimodi
added
the
merge-to-production
|
Hello @dimodi, Check the below option if you would like to automatically generate PR to production. The automation uses the branch for the cherry-pick, and then will delete the branch. Please, do not delete it manually.
|
There was a problem hiding this comment.
Pull Request Overview
This PR updates the ChipList events example to use the default model property names and make the OnRemove handler actually remove items from the source list.
- Removed explicit
TextField,IconField, andRemovableFieldattributes to rely on the component’s defaults. - Enhanced the
OnChipRemovehandler: switched to direct cast, clarified theIsCancelledcomment, and calledChipListSource.Remove. - Renamed
ChipModelproperties toText,Icon, andRemovableto match the defaults.
Comments suppressed due to low confidence (1)
components/chiplist/events.md:50
- [nitpick] Since
IsCancelledalready defaults tofalse, you can remove this explicit assignment and streamline the comment to only explain setting it totruewhen cancellation is needed.
args.IsCancelled = false; // false by default. Set to true to cancel chip removal.
yordan-mitev
approved these changes
May 19, 2025
|
Here you are the link to your PR to production: 2964 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
OnRemove event handler does not do anything. Triggered by 1687649.
Simplify example by removing optional custom model property names.