Draft
Conversation
Packages Report
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR introduces a new focus indicator module, that provides a structured approach to implementing focus states across all Kendo UI components. This module separates the visual structure of focus indicators from their color values. It is built on the existing design system modules - elevation, border radius etc.
Separation of structure and color
Focus indicator patterns define structure (width, offset, style), while colors are applied at the component level.
Structure is defined in the module:
Colors are applied per component
Theme-Specific Configuration Maps
Each theme package contains its own $kendo-focus-indicator map with variants suited to that theme's design language:
Material theme:
Mixins
The module exposes four mixins for different focus indicator patterns:
- focus-indicator-shadow($variant, $color) - generates box-shadow-based focus indicators;
- focus-indicator-outline($variant, $color) - generates outline-based focus indicators;
- focus-indicator-border($color) - generates border-based focus indicators;
- focus-indicator-background($color) - generates background-based focus indicators;
CSS variables
The module generates CSS variables for runtime configuration
--kendo-focus-indicator-shadow: 0 0 0 2px currentColor;
--kendo-focus-indicator-border: 1px solid currentColor;
// ........ etc.
Only colors are fluid
They depend on the component context