Fix spreadsheet validation message formatting regression in kendo.format #8326
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a regression in spreadsheet data validation messages that was introduced in version 2024.4.1112. The issue caused validation messages to display incorrectly formatted text with extra comma-separated values.
Problem
When setting data validation for number-typed cells in the Spreadsheet component, the validation message would appear malformed:
Before (broken):
Expected:
Root Cause
The issue was in the
kendo.format()
function insrc/kendo.core.js
. Instead of receiving properly separated arguments like:The function was receiving malformed arguments where multiple values were incorrectly joined:
Solution
Added robust detection logic to
kendo.format()
that:,,
)number
,text
,date
,custom
,list
) and the comparer messageTesting
The fix includes comprehensive test coverage for:
kendo.format()
usage is unaffectedImpact
Fixes #8302.
💬 Share your feedback on Copilot coding agent for the chance to win a $200 gift card! Click here to start the survey.