-
Notifications
You must be signed in to change notification settings - Fork 220
Spreadsheet: Document the Dialogs property of the ActiveSheetEditor #3140
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change | ||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| @@ -0,0 +1,94 @@ | ||||||||||||||||||
| --- | ||||||||||||||||||
| title: Worksheet Editor Dialogs | ||||||||||||||||||
| page_title: Worksheet Editor Dialogs | ||||||||||||||||||
| description: Check our "Worksheet Editor Dialogs" documentation article for the RadSpreadsheet WPF control. | ||||||||||||||||||
| slug: radspreadsheet-worksheet-editor-dialogs | ||||||||||||||||||
|
||||||||||||||||||
| slug: radspreadsheet-worksheet-editor-dialogs | |
| slug: radspreadsheet-ui-worksheet-editor-dialogs |
Copilot
AI
Mar 6, 2026
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The text says RadWorksheetEditor exposes a Dialog property, but the rest of the article (and the code samples) use Dialogs. This looks like an API name typo and will mislead readers; update the property name so it's consistent and accurate.
| The `RadWorksheetEditor` class provides the `Dialog` property, which is of the type of `WorksheetEditorDialogs`. This class contains properties for each of the dialogs used in the `RadSpreadsheet` control. | |
| The `RadWorksheetEditor` class provides the `Dialogs` property, which is of the type of `WorksheetEditorDialogs`. This class contains properties for each of the dialogs used in the `RadSpreadsheet` control. |
Copilot
AI
Mar 6, 2026
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove the duplicated word "custom" ("custom custom") in this sentence; it reads like a copy/paste typo.
| * `CustomFilterDialog`—Gets or sets the custom filter dialog. To set a custom custom filter dialog, extend the `CustomFilterDialogContent` class. | |
| * `CustomSortListsDialog`—Gets or sets the custom sort lists dialog. To set a custom custom sort lists dialog, extend the `CustomSortListsDialogContent` class. | |
| * `CustomFilterDialog`—Gets or sets the custom filter dialog. To set a custom filter dialog, extend the `CustomFilterDialogContent` class. | |
| * `CustomSortListsDialog`—Gets or sets the custom sort lists dialog. To set a custom sort lists dialog, extend the `CustomSortListsDialogContent` class. |
Copilot
AI
Mar 6, 2026
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove the duplicated word "custom" ("custom custom") in this sentence; it reads like a copy/paste typo.
| * `CustomFilterDialog`—Gets or sets the custom filter dialog. To set a custom custom filter dialog, extend the `CustomFilterDialogContent` class. | |
| * `CustomSortListsDialog`—Gets or sets the custom sort lists dialog. To set a custom custom sort lists dialog, extend the `CustomSortListsDialogContent` class. | |
| * `CustomFilterDialog`—Gets or sets the custom filter dialog. To set a custom filter dialog, extend the `CustomFilterDialogContent` class. | |
| * `CustomSortListsDialog`—Gets or sets the custom sort lists dialog. To set a custom sort lists dialog, extend the `CustomSortListsDialogContent` class. |
Copilot
AI
Mar 6, 2026
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Trailing spaces at the end of this list item will render as a hard line break in Markdown. Remove the extra whitespace to avoid unintended formatting changes.
| * `ConfirmDialog`—Gets or sets the confirm dialog. To set a custom confirm dialog, extend the `ConfirmDialogContent` class. | |
| * `ConfirmDialog`—Gets or sets the confirm dialog. To set a custom confirm dialog, extend the `ConfirmDialogContent` class. |
Copilot
AI
Mar 6, 2026
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"create update" in these sentences is grammatically awkward; consider changing to "create/update" (or "create or update") for readability while keeping the property name as-is.
| * `CreateUpdateSpreadsheetNameDialog`—Gets or sets the create update spreadsheet name dialog. To set a custom create update spreadsheet name dialog, extend the `CreateUpdateSpreadsheetNameDialogContent` class. | |
| * `CreateUpdateSpreadsheetNameDialog`—Gets or sets the create/update spreadsheet name dialog. To set a custom create/update spreadsheet name dialog, extend the `CreateUpdateSpreadsheetNameDialogContent` class. |
Copilot
AI
Mar 6, 2026
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This article describes accessing dialogs via ActiveWorksheetEditor, but the PR title mentions the ActiveSheetEditor path. If the intent is to document ActiveSheetEditor, add an example that uses radSpreadsheet.ActiveSheetEditor and casts it to RadWorksheetEditor before accessing .Dialogs (and clarify when ActiveWorksheetEditor vs ActiveSheetEditor should be used).
Copilot
AI
Mar 6, 2026
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The section says to "inherit from the dialog" to customize it, but the preceding list instructs extending *DialogContent classes and the example inherits from FindAndReplaceDialogContent. Reword this to explicitly say to inherit from the corresponding *DialogContent type to avoid confusion.
| You can customize the dialogs by creating a new class that inherits from the dialog that you want to customize and override the necessary methods to implement your custom logic. | |
| You can customize the dialogs by creating a new class that inherits from the corresponding `*DialogContent` type for the dialog that you want to customize and overriding the necessary methods to implement your custom logic. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Front-matter
descriptionhard-codes "WPF" instead of using the{{ site.framework_name }}token used in other RadSpreadsheet articles. This makes the page inconsistent across framework builds; align it with the standard description pattern.